Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Add warn logging messages to agent-sidecar & ignore io.EOF error when reading metadata.json #608

Merged
merged 4 commits into from
Aug 3, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Aug 3, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Currently, this PR is just for debugging.
Do not merge.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Aug 3, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     🔊 Add debug log for agent-sidecar

     🔊 add error logs to metadata.go

     ♻️ add err != io.EOF to internal/metadata

     🔊 print err

Powered by Pull Assistant. Last update 7ac1599 ... 33fbaf7. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #608 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
- Coverage   12.13%   12.13%   -0.01%     
==========================================
  Files         409      409              
  Lines       21325    21329       +4     
==========================================
  Hits         2588     2588              
- Misses      18452    18456       +4     
  Partials      285      285              
Impacted Files Coverage Δ
pkg/agent/sidecar/service/observer/observer.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2348bba...33fbaf7. Read the comment docs.

@rinx
Copy link
Contributor Author

rinx commented Aug 3, 2020

/rebase
/format

@rinx rinx changed the title [DNM] Add debug log for agent-sidecar Add warn logging messages to agent-sidecar & ignore io.EOF error when reading metadata.json Aug 3, 2020
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2020

[REBASE] Rebase triggered by rinx for branch: refactor/agent-sidecar/add-debug-logs

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the refactor/agent-sidecar/add-debug-logs branch from 3af917d to 33fbaf7 Compare August 3, 2020 03:45
@rinx rinx marked this pull request as ready for review August 3, 2020 03:45
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2020

[FORMAT] Updating license headers and formatting go codes triggered by rinx.

@kpango
Copy link
Collaborator

kpango commented Aug 3, 2020

/rebase
/format
/changelog
/approve

@kpango kpango changed the title Add warn logging messages to agent-sidecar & ignore io.EOF error when reading metadata.json [patch] Add warn logging messages to agent-sidecar & ignore io.EOF error when reading metadata.json Aug 3, 2020
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2020

[CHANGELOG] Please edit the following lines.

  • Add warn logging messages to agent-sidecar & ignore io.EOF error when reading metadata.json (#608)
  • Add DB metrics: Cassandra (#587)
  • ♻️ Improve Singleflight performance (#580)
  • 📝 add delete dataflow in architecture document (#591)
  • ♻️ Add gaussian random vector generation (#595)
  • ♻️ ✅ Refactoring internal/db/kvs/redis package (#590)
  • 💚 Add reviewdog - markdown: LanguageTool (#604)
  • 💚 Add reviewdog - hadolint (#603)
  • 🤖 Automatically update k8s manifests (#599)

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2020

[REBASE] Rebase triggered by kpango for branch: refactor/agent-sidecar/add-debug-logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2020

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

@kpango kpango merged commit eaf0e44 into master Aug 3, 2020
@kpango kpango deleted the refactor/agent-sidecar/add-debug-logs branch August 3, 2020 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants