use internal client #618

kmrmt · 2020-08-07T05:30:10Z

Description:

fix load test using internal client and add option about resolve DNS

Related Issue:

#557

How Has This Been Tested?:

Nothing.

Environment:

Go Version: 1.14.4
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.0

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-08-07T05:30:12Z

Best reviewed: commit by commit

Optimal code review plan (1 warning)

use internal client

...tools/cli/loadtest/sample.yaml 50% changes removed in use config.GRPCClien...

fix test

use config.GRPCClient.ConnectionPool.ResolveDNS

Powered by Pull Assistant. Last update 6ff3b54 ... f31bd51. Read the comment docs.

vdaas-ci · 2020-08-07T05:30:26Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

pkg/tools/cli/loadtest/service/loader.go

codecov · 2020-08-07T05:38:59Z

Codecov Report

Merging #618 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   15.35%   15.36%           
=======================================
  Files         412      412           
  Lines       21629    21626    -3     
=======================================
+ Hits         3321     3322    +1     
+ Misses      18060    18056    -4     
  Partials      248      248

Impacted Files	Coverage Δ
pkg/tools/cli/loadtest/service/loader.go	`0.00% <0.00%> (ø)`
pkg/tools/cli/loadtest/usecase/load.go	`0.00% <0.00%> (ø)`
internal/worker/worker.go	`84.54% <0.00%> (+0.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720aaa9...f31bd51. Read the comment docs.

pkg/tools/cli/loadtest/config/config.go

hlts2

LGTM

kevindiu

LGTM

vankichi

LGTM

vankichi · 2020-09-07T09:16:35Z

/rebase
/format

vdaas-ci · 2020-09-07T09:17:12Z

[REBASE] Rebase triggered by vankichi for branch: feature/benchmark/fix_load_test_using_internal_client

vdaas-ci · 2020-09-07T09:18:07Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci · 2020-09-07T09:18:56Z

[FORMAT] Failed to format.

vankichi · 2020-09-07T09:26:38Z

/format

vdaas-ci · 2020-09-07T09:27:58Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci · 2020-09-07T09:28:35Z

[FORMAT] Failed to format.

kevindiu

LGTM

vankichi · 2020-09-09T01:27:51Z

/rebase
/format

vdaas-ci · 2020-09-09T01:28:30Z

[REBASE] Rebase triggered by vankichi for branch: feature/benchmark/fix_load_test_using_internal_client

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

vdaas-ci · 2020-09-09T01:29:23Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vankichi · 2020-09-09T06:22:03Z

/approve

vdaas-ci

[APPROVED] This PR is approved by vankichi.

github-actions bot added area/tools/cli/loadtest size/M type/feature New feature priority/medium labels Aug 7, 2020

github-actions bot reviewed Aug 7, 2020

View reviewed changes

pkg/tools/cli/loadtest/service/loader.go Show resolved Hide resolved

pkg/tools/cli/loadtest/service/loader.go Show resolved Hide resolved

kmrmt added the team/set SET team label Aug 19, 2020

kmrmt force-pushed the feature/benchmark/fix_load_test_using_internal_client branch from b429c56 to b0e3b14 Compare August 19, 2020 11:58

kpango reviewed Aug 20, 2020

View reviewed changes

pkg/tools/cli/loadtest/config/config.go Outdated Show resolved Hide resolved

kmrmt requested review from a team, kevindiu, vankichi and hlts2 and removed request for a team and vankichi September 1, 2020 06:09

hlts2 previously approved these changes Sep 2, 2020

View reviewed changes

kevindiu previously approved these changes Sep 2, 2020

View reviewed changes

kmrmt requested a review from vankichi September 2, 2020 05:22

vankichi previously approved these changes Sep 7, 2020

View reviewed changes

vdaas-ci dismissed stale reviews from vankichi, kevindiu, and hlts2 via 635ebf8 September 7, 2020 09:17

vdaas-ci force-pushed the feature/benchmark/fix_load_test_using_internal_client branch from 70a6369 to 635ebf8 Compare September 7, 2020 09:17

kevindiu previously approved these changes Sep 8, 2020

View reviewed changes

kmrmt added 3 commits September 9, 2020 01:28

use internal client

6ff3b54

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

fix test

a6c3d8f

use config.GRPCClient.ConnectionPool.ResolveDNS

f31bd51

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

vdaas-ci dismissed kevindiu’s stale review via f31bd51 September 9, 2020 01:28

vdaas-ci force-pushed the feature/benchmark/fix_load_test_using_internal_client branch from 635ebf8 to f31bd51 Compare September 9, 2020 01:28

vdaas-ci approved these changes Sep 9, 2020

View reviewed changes

vankichi merged commit dc3563d into master Sep 9, 2020

vankichi deleted the feature/benchmark/fix_load_test_using_internal_client branch September 9, 2020 06:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use internal client #618

use internal client #618

kmrmt commented Aug 7, 2020

pull-assistant bot commented Aug 7, 2020 •

edited

Loading

vdaas-ci commented Aug 7, 2020

codecov bot commented Aug 7, 2020 •

edited

Loading

hlts2 left a comment

kevindiu left a comment

vankichi left a comment

vankichi commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

vankichi commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

kevindiu left a comment

vankichi commented Sep 9, 2020

vdaas-ci commented Sep 9, 2020

vdaas-ci commented Sep 9, 2020

vankichi commented Sep 9, 2020

vdaas-ci left a comment

use internal client #618

use internal client #618

Conversation

kmrmt commented Aug 7, 2020

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Aug 7, 2020 • edited Loading

vdaas-ci commented Aug 7, 2020

codecov bot commented Aug 7, 2020 • edited Loading

Codecov Report

hlts2 left a comment

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

vankichi commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

kevindiu left a comment

Choose a reason for hiding this comment

vankichi commented Sep 9, 2020

vdaas-ci commented Sep 9, 2020

vdaas-ci commented Sep 9, 2020

vankichi commented Sep 9, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

pull-assistant bot commented Aug 7, 2020 •

edited

Loading

codecov bot commented Aug 7, 2020 •

edited

Loading