Add test case for storage/blob/s3/writer/option

[hlts2]

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I added test cases for option.go and refactored option.go.

Refactor Contents

• warn output when FOP returns error
• returns an error when the argument of FOP is invalid.
• validation logic
  => if we do not notice that the invalid value is set at startup and an error occurs based on UploadWithContext after startup, we will lose our backup data.
• check type of empty string.

str != "" 
↓
len(str) != 0

Related issue

• Default value is used when options failed without notifying user #585

author review required

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.14.4
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.0

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan (2 warnings)

     feat: add test and new validation logic

     fix: const value

     feat: add ignore options for goleak

     fix: apply suggestion

     feat: error for option

feat: add option error

internal/errors/option.go 67% changes removed in feat: add option err...

fix: guideline

...s/contributing/coding-style.md 67% changes removed in Update docs/contribu...

     fix: lint error

     Update docs/contributing/coding-style.md

     Update docs/contributing/coding-style.md

     Update docs/contributing/coding-style.md

     Update docs/contributing/coding-style.md

     Update docs/contributing/coding-style.md

     feat: add option error type

     Update docs/contributing/coding-style.md

     Update docs/contributing/coding-style.md

     feat: add test case

     Update internal/db/storage/blob/s3/writer/option_test.go

     fix: apply suggestion

     🤖 Update license headers / Format go codes and yaml files

Powered by Pull Assistant. Last update cffbece ... 78db402. Read the comment docs.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[codecov]

Codecov Report

Merging #656 into master will increase coverage by 0.14%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   15.24%   15.39%   +0.14%     
==========================================
  Files         411      412       +1     
  Lines       21578    21598      +20     
==========================================
+ Hits         3290     3324      +34     
+ Misses      18036    18026      -10     
+ Partials      252      248       -4     

Impacted Files	Coverage Δ
internal/db/storage/blob/s3/writer/writer.go	0.00% <0.00%> (ø)
internal/errors/option.go	0.00% <0.00%> (ø)
internal/db/storage/blob/s3/writer/option.go	100.00% <100.00%> (+85.71%)	⬆️
internal/worker/worker.go	85.45% <0.00%> (+0.90%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0c37e...78db402. Read the comment docs.

[kevindiu]

please commit this
https://github.com/vdaas/vald/pull/656/files#r481934372

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

[vdaas-ci]

[APPROVED] This PR is approved by kpango.

[vankichi]

/rebase
/format
/approve

[vdaas-ci]

[REBASE] Rebase triggered by vankichi for branch: test/internal/storage_blob_s3_writer_option

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

[vdaas-ci]

[APPROVED] This PR is approved by vankichi.