Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for storage/blob/s3/writer/option #656

Merged
merged 20 commits into from
Sep 4, 2020
Merged

Add test case for storage/blob/s3/writer/option #656

merged 20 commits into from
Sep 4, 2020

Commits on Sep 4, 2020

  1. feat: add test and new validation logic 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    cffbece View commit details
    Browse the repository at this point in the history

  2. fix: const value 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    eeb5187 View commit details
    Browse the repository at this point in the history

  3. feat: add ignore options for goleak 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    14e33c0 View commit details
    Browse the repository at this point in the history

  4. fix: apply suggestion 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    6e9193e View commit details
    Browse the repository at this point in the history

  5. feat: error for option 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    38c75ea View commit details
    Browse the repository at this point in the history

  6. feat: add option error 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    886c1eb View commit details
    Browse the repository at this point in the history

  7. fix: guideline 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    df605ab View commit details
    Browse the repository at this point in the history

  8. fix: lint error 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    d80cf50 View commit details
    Browse the repository at this point in the history

  9. Update docs/contributing/coding-style.md 

    Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
    @hlts2 @kevindiu @actions-user
    2 people authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    681e762 View commit details
    Browse the repository at this point in the history

  10. Update docs/contributing/coding-style.md

    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    cc1e82a View commit details
    Browse the repository at this point in the history

  11. Update docs/contributing/coding-style.md

    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    37a063f View commit details
    Browse the repository at this point in the history

  12. Update docs/contributing/coding-style.md

    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    722f331 View commit details
    Browse the repository at this point in the history

  13. Update docs/contributing/coding-style.md

    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    a091f26 View commit details
    Browse the repository at this point in the history

  14. feat: add option error type 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    f7e6b60 View commit details
    Browse the repository at this point in the history

  15. Update docs/contributing/coding-style.md

    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    57c4458 View commit details
    Browse the repository at this point in the history

  16. Update docs/contributing/coding-style.md

    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    0676c64 View commit details
    Browse the repository at this point in the history

  17. feat: add test case 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    29c6c41 View commit details
    Browse the repository at this point in the history

  18. Update internal/db/storage/blob/s3/writer/option_test.go

    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    41057ca View commit details
    Browse the repository at this point in the history

  19. fix: apply suggestion 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @actions-user
    hlts2 authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    fb2d59c View commit details
    Browse the repository at this point in the history

  20. 🤖 Update license headers / Format go codes and yaml files 

    Signed-off-by: vdaas-ci <ci@vdaas.org>
    @vdaas-ci @actions-user
    vdaas-ci authored and actions-user committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    78db402 View commit details
    Browse the repository at this point in the history