-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Docker build command to update latest tags & nightly label #890
Merged
kpango
merged 2 commits into
master
from
feature/apis/v1-new-design-update-docker-image-tag
Jan 20, 2021
Merged
Revise Docker build command to update latest tags & nightly label #890
kpango
merged 2 commits into
master
from
feature/apis/v1-new-design-update-docker-image-tag
Jan 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/makefile
team/sre
SRE team
type/ci
size/XXXL
type/feature
New feature
priority/medium
labels
Dec 16, 2020
rinx
force-pushed
the
feature/apis/v1-new-design-update-docker-image-tag
branch
3 times, most recently
from
December 23, 2020 07:01
8de4418
to
db9df0b
Compare
rinx
force-pushed
the
feature/apis/v1-new-design-update-docker-image-tag
branch
from
December 24, 2020 02:42
db9df0b
to
8bb9191
Compare
rinx
force-pushed
the
feature/apis/v1-new-design-update-docker-image-tag
branch
from
January 6, 2021 02:24
8bb9191
to
d983752
Compare
kpango
force-pushed
the
feature/apis/v1-new-design
branch
from
January 11, 2021 06:55
9fd2f8c
to
9e0ef83
Compare
rinx
force-pushed
the
feature/apis/v1-new-design-update-docker-image-tag
branch
2 times, most recently
from
January 12, 2021 01:54
f945652
to
ec112de
Compare
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
rinx
force-pushed
the
feature/apis/v1-new-design-update-docker-image-tag
branch
from
January 20, 2021 04:54
ec112de
to
d2a393e
Compare
kpango
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kpango thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com
Description:
Revised Docker build command on CI to update latest tags on version releases.
Also, I updated the CI to put "version=nightly" label to
vald_app_version_info
Prometheus exporter.Temporarily the base branch is feature/apis/v1-new-design, but it is okay to merge this PR into master after #826 is merged into master. Once #826 merged into master, the base branch will be changed to master.Related Issue:
Nothing.
How Has This Been Tested?:
Nothing.
Environment:
Types of changes:
Changes to Core Features:
Checklist: