Bug fix for gateway #963

kpango · 2021-01-29T06:21:30Z

Signed-off-by: kpango kpango@vdaas.org

Description:

bug fix of gateway for v1 release

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.7
Docker Version: 20.10.0-rc2
Kubernetes Version: 1.20.2
NGT Version: 1.13.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

Signed-off-by: kpango <kpango@vdaas.org>

vdaas-ci · 2021-01-29T06:21:48Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

kpango · 2021-01-29T06:23:28Z

/changelog

vdaas-ci · 2021-01-29T06:23:53Z

[CHANGELOG] Please edit the following lines.

New Feature

The Vald-Gateway has been divided into four Gateways (LB, Meta, Backup and Filter).
API returns correct status and detailed error message.
StreamAPI returns detailed error status payload for each chunked requests were failed
improved vald network component performance
improved observability for each function
structured helm chart for managers and gateways
Filter gateway is now GA, Users can issue requests with extracted feature vectors inline for search/insert/update/upsert requests.
gRPC proto files are now Versioned for future changes
users can access Vald agent using vald api client.
internal/client packages are now GA, each vald component can use it for effective connection management and easily to send reqest.
Trace & logger grpc Interceptor

Breaking Changes

API interface changed.
Helm Chart changed.
Vald-gateway will be deprecated in a future version.
k8s controller-runtime updated internal/k8s controller is now new context interface
Vald Agent now uses same API definition as vald v1 gateway interface.

PRs

Remove actions/cache to improve workflow speed / Refactoring docker-build workflows (#957)
add filter gateway (#948)
Add Zap logger and access log interceptor (#944)
Add test case for internal/errors/mysql.go (#918)
Fix invalid data loading code in example (#949)
Add option to use networking.k8s.io/v1beta1 ingresses (#945)
(bugfix gateway-lb nil pointer panic due to nil filter configuration #943))
update rbac.authorization.k8s.io v1beta1 to v1 (#942)
Update Grafana dashboards (#940)
Add a gRPC interceptor for embedding payloads into trace spans (#900)
add goleak.IgnoreCurrent option for Parallel testing (#941)
update go modules (#939)
🤖 Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#937)
⚡ Revise build command for multiplatforms (#890)
update dependencies (#935)
E2E deploy test: rewrite in go tests (#814)
create unit test guideline (#869)
feature/apis/change grpc error object (#934)
Add test case for internal/errors/http.go (#908)
🤖 Update license headers / Format Go codes and YAML files (#933)
revise kubelinter config / Add securityContext section to Helm chart (#833)
os.free nil pointer failure in ngt cgo due to create index hang up (#930)
change grpc bidi-stream error handling and change grpc API interface (#928)
fix unclosed string literal in Dockerfile's ARG MAINTAINER (#923)
Revise building workflow of ci and dev containers (#922)
bugfix add nil check for grpc connection pool objects in grpc/client.go (#921)
remove unneccessary pr-tag definition from chart (#920)
📝 Fix typo in gateway-vald configmap template (#919)
change docker base image PRIMARY_TAG name from nightly to latest (#917)
💚 Use vdaas-ci token for making commits (#895)
Vald V1 New Design APIs (#826)
🤖 Automatically update k8s manifests (#914)

kevindiu

LGTM.
Happy birthday 👏

hlts2

LGTM 👍

rinx · 2021-01-29T07:08:37Z

I'm not sure but the several dependencies are updated in this PR. Is that okay?

kpango · 2021-01-29T07:15:54Z

@rinx I think it's okay, because each dependency are small update and I checked this build on my local cluster it works fine.

If you interest please check below each one looks not breaking changes and just update small things.
apache/cassandra-gocql-driver@9e3bb6c...14aa133
census-ecosystem/opencensus-go-exporter-stackdriver@v0.13.4...v0.13.5
https://github.com/aws/aws-sdk-go/releases/tag/v1.37.0
lucasb-eyer/go-colorful@v1.0.3...v1.2.0

kpango · 2021-01-29T07:32:22Z

@rinx seems e2e test failed to deploy mysql.
Recently kubectl command may not find the resource even if you run a watch request immediately after deployment!
So I recently added the sleep command for scylla and it works.

example
https://github.com/vdaas/vald/blob/master/Makefile.d/k8s.mk#L261
https://github.com/vdaas/vald/blob/master/Makefile.d/k8s.mk#L282

should I add sleep command for each wait for command?

rinx · 2021-01-29T07:34:03Z

yes, please.

kpango · 2021-01-29T07:34:16Z

okay, I'll do it.

Signed-off-by: kpango <kpango@vdaas.org>

rinx · 2021-01-29T07:36:30Z

Maybe E2E tests for deploying with Cassandra requires changes like this.
442e82d

Signed-off-by: kpango <kpango@vdaas.org>

kpango · 2021-01-29T07:42:57Z

@rinx thank you for your attention, I updated .github/helm/values/values-scylla.yaml

pkg/gateway/backup/handler/grpc/handler.go

github-actions · 2021-02-01T11:06:53Z

pkg/gateway/backup/handler/grpc/handler.go

 		for _, req := range reqs.GetRequests() {
-			removeList = append(removeList, &payload.Remove_Request{
+			rmr.Requests = append(rmr.Requests, &payload.Remove_Request{


🚫 [golangci] _{reported by reviewdog 🐶}
Config, XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in Remove_Request (exhaustivestruct)

github-actions · 2021-02-01T11:06:53Z

pkg/gateway/backup/handler/grpc/handler.go

+			vec.Config.SkipStrictExistCheck = true
+		}
+		ids = append(ids, vec.GetVector().GetId())
+		ireqs = append(ireqs, &payload.Insert_Request{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in Insert_Request (exhaustivestruct)

github-actions · 2021-02-01T11:06:54Z

pkg/gateway/backup/handler/grpc/handler.go

+		ids = append(ids, vec.GetVector().GetId())
+		ireqs = append(ireqs, &payload.Insert_Request{
+			Vector: vec.GetVector(),
+			Config: &payload.Insert_Config{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in Insert_Config (exhaustivestruct)

github-actions · 2021-02-01T11:06:54Z

pkg/gateway/backup/handler/grpc/handler.go

 	}
-	res, err = s.MultiInsert(ctx, &payload.Insert_MultiRequest{
+	log.Debugf("uuids %v were removed from %v for MultiUpdate it will execute MultiInsert soon, see detailt %#v", ids, locs.GetLocations(), locs)
+	locs, err = s.MultiInsert(ctx, &payload.Insert_MultiRequest{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in Insert_MultiRequest (exhaustivestruct)

github-actions · 2021-02-01T11:06:54Z

pkg/gateway/backup/handler/grpc/handler.go

@@ -783,35 +1423,61 @@ func (s *server) GetObject(ctx context.Context, req *payload.Object_VectorReques
 		}
 	}()
 	mvec, err := s.backup.GetVector(ctx, req.GetId().GetId())
+	if err == nil && mvec != nil {
+		return &payload.Object_Vector{


🚫 [golangci] _{reported by reviewdog 🐶}
XXX_NoUnkeyedLiteral, XXX_unrecognized, XXX_sizecache are missing in Object_Vector (exhaustivestruct)

github-actions · 2021-02-01T11:33:07Z

internal/net/grpc/errdetails/errdetails.go

@@ -37,3 +40,16 @@ type (
 	ResourceInfo                 = errdetails.ResourceInfo
 	RetryInfo                    = errdetails.RetryInfo
 )
+
+const (
+	ValdResourceOwner          = "vdaas.org vald team <vald@vdaas.org>"


🚫 [golangci] _{reported by reviewdog 🐶}
exported const ValdResourceOwner should have comment (or a comment on this block) or be unexported (golint)

github-actions · 2021-02-01T11:33:07Z

internal/net/grpc/errdetails/errdetails.go

+	ValdGRPCResourceTypePrefix = "github.com/vdaas/vald/apis/grpc/v1"
+)
+
+func Serialize(obj interface{}) string {


🚫 [golangci] _{reported by reviewdog 🐶}
exported function Serialize should have comment or be unexported (golint)

github-actions · 2021-02-01T11:33:07Z

internal/net/grpc/stream.go

 			}
 			if data != nil {
 				eg.Go(safety.RecoverWithoutPanicFunc(func() (err error) {
+					ctx, sspan := trace.StartSpan(ctx, fmt.Sprintf("%s/BidirectionalStream/stream-%020d", apiName, atomic.AddUint64(&cnt, 1)))


🚫 [golangci] _{reported by reviewdog 🐶}
line is 127 characters (lll)

Signed-off-by: kpango <kpango@vdaas.org>

github-actions · 2021-02-01T11:45:11Z

pkg/gateway/meta/handler/grpc/handler.go

 		if span != nil {
 			span.SetStatus(trace.StatusCodeNotFound(err.Error()))
 		}
-		return nil, status.WrapWithNotFound(fmt.Sprintf("Exists API meta %s's uuid not found", meta.GetId()), err, meta.GetId(), info.Get())
+		return nil, err


🚫 [golangci] _{reported by reviewdog 🐶}
return statements should not be cuddled if block has more than two lines (wsl)

github-actions · 2021-02-01T11:45:11Z

pkg/gateway/meta/handler/grpc/handler.go

+		if span != nil {
+			span.SetStatus(trace.StatusCodeInternal(err.Error()))
+		}
+		log.Error(err)


🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

github-actions · 2021-02-01T11:45:11Z

pkg/gateway/meta/handler/grpc/handler.go

+		if span != nil {
+			span.SetStatus(trace.StatusCodeInternal(err.Error()))
+		}
+		log.Error(err)


🚫 [golangci] _{reported by reviewdog 🐶}
expressions should not be cuddled with blocks (wsl)

github-actions · 2021-02-01T11:45:11Z

pkg/gateway/meta/handler/grpc/handler.go

+			}
+			return nil, err
+		}
+		ids = append(ids, meta)


🚫 [golangci] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

github-actions · 2021-02-01T11:45:11Z

internal/net/grpc/stream.go

@@ -84,26 +98,39 @@ func BidirectionalStream(ctx context.Context, stream ServerStream,
 			data := newData()
 			err = stream.RecvMsg(data)
 			if err != nil {
-				if err == io.EOF || errors.Is(err, io.EOF) {
-					return finalize()
+				if err != io.EOF && !errors.Is(err, io.EOF) {


🚫 [golangci] _{reported by reviewdog 🐶}
comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)

Signed-off-by: kpango <kpango@vdaas.org>

github-actions · 2021-02-01T13:05:27Z

pkg/gateway/meta/handler/grpc/handler.go

 	}
 	return loc, nil
 }

-func (s *server) StreamInsert(stream vald.Insert_StreamInsertServer) error {
+func (s *server) StreamInsert(stream vald.Insert_StreamInsertServer) (err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
635-683 lines are duplicate of pkg/gateway/meta/handler/grpc/handler.go:911-959 (dupl)

github-actions · 2021-02-01T13:05:27Z

pkg/gateway/meta/handler/grpc/handler.go

 	}
 	return res, nil
 }

-func (s *server) StreamUpdate(stream vald.Update_StreamUpdateServer) error {
+func (s *server) StreamUpdate(stream vald.Update_StreamUpdateServer) (err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
911-959 lines are duplicate of pkg/gateway/meta/handler/grpc/handler.go:1118-1166 (dupl)

github-actions · 2021-02-01T13:05:27Z

pkg/gateway/meta/handler/grpc/handler.go

 	}
 	return loc, nil
 }

-func (s *server) StreamUpsert(stream vald.Upsert_StreamUpsertServer) error {
+func (s *server) StreamUpsert(stream vald.Upsert_StreamUpsertServer) (err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
1118-1166 lines are duplicate of pkg/gateway/meta/handler/grpc/handler.go:1371-1419 (dupl)

github-actions · 2021-02-01T13:05:27Z

pkg/gateway/meta/handler/grpc/handler.go

 	}
 	return loc, nil
 }

-func (s *server) StreamRemove(stream vald.Remove_StreamRemoveServer) error {
+func (s *server) StreamRemove(stream vald.Remove_StreamRemoveServer) (err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
1371-1419 lines are duplicate of pkg/gateway/meta/handler/grpc/handler.go:1546-1594 (dupl)

github-actions · 2021-02-01T13:05:27Z

pkg/gateway/meta/handler/grpc/handler.go

 	}
 	vec.Id = meta
 	return vec, nil
 }

-func (s *server) StreamGetObject(stream vald.Object_StreamGetObjectServer) error {
+func (s *server) StreamGetObject(stream vald.Object_StreamGetObjectServer) (err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
1546-1594 lines are duplicate of pkg/gateway/meta/handler/grpc/handler.go:635-683 (dupl)

github-actions · 2021-02-01T13:05:28Z

pkg/gateway/lb/handler/grpc/handler.go

 	}
 	return loc, nil
 }

-func (s *server) StreamUpsert(stream vald.Upsert_StreamUpsertServer) error {
+func (s *server) StreamUpsert(stream vald.Upsert_StreamUpsertServer) (err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
1352-1400 lines are duplicate of pkg/gateway/lb/handler/grpc/handler.go:1611-1659 (dupl)

github-actions · 2021-02-01T13:05:28Z

pkg/gateway/lb/handler/grpc/handler.go

 	}
 	return locs, nil
 }

-func (s *server) StreamRemove(stream vald.Remove_StreamRemoveServer) error {
+func (s *server) StreamRemove(stream vald.Remove_StreamRemoveServer) (err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
1611-1659 lines are duplicate of pkg/gateway/lb/handler/grpc/handler.go:1796-1844 (dupl)

github-actions · 2021-02-01T13:05:29Z

pkg/gateway/lb/handler/grpc/handler.go

 	}
 	return vec, nil
 }

-func (s *server) StreamGetObject(stream vald.Object_StreamGetObjectServer) error {
+func (s *server) StreamGetObject(stream vald.Object_StreamGetObjectServer) (err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
1796-1844 lines are duplicate of pkg/gateway/lb/handler/grpc/handler.go:819-867 (dupl)

github-actions · 2021-02-01T13:05:29Z

pkg/gateway/lb/handler/grpc/handler.go

+		return nil, err
+	}
+
+	if !req.GetConfig().GetSkipStrictExistCheck() {


🚫 [golangci] _{reported by reviewdog 🐶}
1019-1045 lines are duplicate of pkg/gateway/lb/handler/grpc/handler.go:1187-1213 (dupl)

github-actions · 2021-02-01T13:05:29Z

pkg/gateway/lb/handler/grpc/handler.go

+			return nil, err
+		}
+		uuid := vec.GetVector().GetId()
+		if !vec.GetConfig().GetSkipStrictExistCheck() {


🚫 [golangci] _{reported by reviewdog 🐶}
1187-1213 lines are duplicate of pkg/gateway/lb/handler/grpc/handler.go:1019-1045 (dupl)

Signed-off-by: kpango <kpango@vdaas.org>

github-actions · 2021-02-02T04:52:44Z

internal/net/grpc/types/types.go

+	"github.com/gogo/protobuf/types"
+)
+
+type Any = types.Any


🚫 [golangci] _{reported by reviewdog 🐶}
exported type Any should have comment or be unexported (golint)

github-actions · 2021-02-02T04:52:45Z

internal/net/grpc/types/types.go

+
+type Any = types.Any
+
+func UnmarshalAny(any *Any, pb proto.Message) error {


🚫 [golangci] _{reported by reviewdog 🐶}
exported function UnmarshalAny should have comment or be unexported (golint)

github-actions · 2021-02-02T04:52:45Z

internal/net/grpc/errdetails/errdetails.go

+	return fmt.Sprintf("code: %d,\tmessage: %s,\terror: %v,details: %v", e.Code, e.Message, e.Error, e.Details)
+}
+
+func DecodeErrorDetails(objs ...interface{}) (es []*ErrorDetails) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function 'DecodeErrorDetails' has too many statements (47 > 40) (funlen)

github-actions · 2021-02-02T04:52:45Z

internal/net/grpc/errdetails/errdetails.go

+	return string(b)
+}
+
+func DecodeDetail(detail *types.Any) (data interface{}, err error) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function 'DecodeDetail' has too many statements (58 > 40) (funlen)

github-actions · 2021-02-02T04:52:45Z

internal/net/grpc/errdetails/errdetails.go

+)
+
+var (
+	debugInfoMessageName                    = new(DebugInfo).XXX_MessageName()


🚫 [golangci] _{reported by reviewdog 🐶}
debugInfoMessageName is a global variable (gochecknoglobals)

github-actions · 2021-02-02T04:52:45Z

internal/net/grpc/errdetails/errdetails.go

+	preconditionFailureViolationMessageName = new(PreconditionFailureViolation).XXX_MessageName()
+	helpMessageName                         = new(Help).XXX_MessageName()
+	helpLinkMessageName                     = new(HelpLink).XXX_MessageName()
+	quotaFailureMessageName                 = new(QuotaFailure).XXX_MessageName()


🚫 [golangci] _{reported by reviewdog 🐶}
quotaFailureMessageName is a global variable (gochecknoglobals)

github-actions · 2021-02-02T04:52:46Z

internal/net/grpc/errdetails/errdetails.go

+	helpMessageName                         = new(Help).XXX_MessageName()
+	helpLinkMessageName                     = new(HelpLink).XXX_MessageName()
+	quotaFailureMessageName                 = new(QuotaFailure).XXX_MessageName()
+	quotaFailureViolationMessageName        = new(QuotaFailureViolation).XXX_MessageName()


🚫 [golangci] _{reported by reviewdog 🐶}
quotaFailureViolationMessageName is a global variable (gochecknoglobals)

github-actions · 2021-02-02T04:52:46Z

internal/net/grpc/errdetails/errdetails.go

+	helpLinkMessageName                     = new(HelpLink).XXX_MessageName()
+	quotaFailureMessageName                 = new(QuotaFailure).XXX_MessageName()
+	quotaFailureViolationMessageName        = new(QuotaFailureViolation).XXX_MessageName()
+	requestInfoMessageName                  = new(RequestInfo).XXX_MessageName()


🚫 [golangci] _{reported by reviewdog 🐶}
requestInfoMessageName is a global variable (gochecknoglobals)

github-actions · 2021-02-02T04:52:46Z

internal/net/grpc/errdetails/errdetails.go

+	quotaFailureMessageName                 = new(QuotaFailure).XXX_MessageName()
+	quotaFailureViolationMessageName        = new(QuotaFailureViolation).XXX_MessageName()
+	requestInfoMessageName                  = new(RequestInfo).XXX_MessageName()
+	resourceInfoMessageName                 = new(ResourceInfo).XXX_MessageName()


🚫 [golangci] _{reported by reviewdog 🐶}
resourceInfoMessageName is a global variable (gochecknoglobals)

github-actions · 2021-02-02T04:52:46Z

internal/net/grpc/errdetails/errdetails.go

+	quotaFailureViolationMessageName        = new(QuotaFailureViolation).XXX_MessageName()
+	requestInfoMessageName                  = new(RequestInfo).XXX_MessageName()
+	resourceInfoMessageName                 = new(ResourceInfo).XXX_MessageName()
+	retryInfoMessageName                    = new(RetryInfo).XXX_MessageName()


🚫 [golangci] _{reported by reviewdog 🐶}
retryInfoMessageName is a global variable (gochecknoglobals)

V1.0.0 Stable Release

4a9818d

Signed-off-by: kpango <kpango@vdaas.org>

kpango changed the title ~~V1.0.0 Stable Release~~ [major] V1.0.0 Stable Release Jan 29, 2021

github-actions bot added team/sre SRE team type/ci size/S priority/low labels Jan 29, 2021

kevindiu previously approved these changes Jan 29, 2021

View reviewed changes

hlts2 previously approved these changes Jan 29, 2021

View reviewed changes

rinx previously approved these changes Jan 29, 2021

View reviewed changes

kpango requested review from datelier and vankichi January 29, 2021 07:21

rinx added the actions/e2e-deploy label Jan 29, 2021

add sleep command for kubeclt wait for

9711da3

Signed-off-by: kpango <kpango@vdaas.org>

kpango dismissed stale reviews from rinx, hlts2, and kevindiu via 9711da3 January 29, 2021 07:36

github-actions bot added the area/makefile label Jan 29, 2021

add scylla initializer for e2e

63067ed

Signed-off-by: kpango <kpango@vdaas.org>

rinx added actions/e2e-deploy and removed actions/e2e-deploy labels Jan 29, 2021

github-actions bot reviewed Feb 1, 2021

View reviewed changes

kpango added actions/e2e-deploy and removed actions/e2e-deploy labels Feb 1, 2021

github-actions bot reviewed Feb 1, 2021

View reviewed changes

add error detail logging for e2e test

24a9d97

Signed-off-by: kpango <kpango@vdaas.org>

kpango force-pushed the release/v1/v1.0.0-stable-release branch from 0b4a414 to 24a9d97 Compare February 1, 2021 11:38

kpango added actions/e2e-deploy and removed actions/e2e-deploy labels Feb 1, 2021

github-actions bot reviewed Feb 1, 2021

View reviewed changes

kpango added 2 commits February 1, 2021 21:24

fix

f172b77

Signed-off-by: kpango <kpango@vdaas.org>

fix

57269ff

Signed-off-by: kpango <kpango@vdaas.org>

kpango force-pushed the release/v1/v1.0.0-stable-release branch from 975e69e to 57269ff Compare February 1, 2021 12:58

kpango added actions/e2e-deploy and removed actions/e2e-deploy labels Feb 1, 2021

github-actions bot reviewed Feb 1, 2021

View reviewed changes

add e2e make command

cca2b7c

Signed-off-by: kpango <kpango@vdaas.org>

kpango force-pushed the release/v1/v1.0.0-stable-release branch from abbfa88 to cca2b7c Compare February 1, 2021 13:58

rinx added actions/e2e-deploy and removed actions/e2e-deploy labels Feb 2, 2021

add more detailed error proto message serialier

02850eb

Signed-off-by: kpango <kpango@vdaas.org>

kpango force-pushed the release/v1/v1.0.0-stable-release branch from 4370141 to 02850eb Compare February 2, 2021 04:45

Merge branch 'master' into release/v1/v1.0.0-stable-release

52c9b3a

kpango added actions/e2e-deploy and removed actions/e2e-deploy labels Feb 2, 2021

github-actions bot reviewed Feb 2, 2021

View reviewed changes

kpango merged commit 660684a into master Feb 2, 2021

kpango deleted the release/v1/v1.0.0-stable-release branch February 2, 2021 05:24

vdaas-ci mentioned this pull request Feb 2, 2021

[major] v1.0.0 Release #974

Merged

11 tasks


		type Any = types.Any

		func UnmarshalAny(any *Any, pb proto.Message) error {

Bug fix for gateway #963

Bug fix for gateway #963

Conversation

kpango commented Jan 29, 2021 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Jan 29, 2021

kpango commented Jan 29, 2021

vdaas-ci commented Jan 29, 2021 • edited by kpango Loading

New Feature

Breaking Changes

PRs

kevindiu left a comment

Choose a reason for hiding this comment

hlts2 left a comment • edited Loading

Choose a reason for hiding this comment

rinx commented Jan 29, 2021

kpango commented Jan 29, 2021 • edited Loading

kpango commented Jan 29, 2021 • edited Loading

rinx commented Jan 29, 2021

kpango commented Jan 29, 2021

rinx commented Jan 29, 2021

kpango commented Jan 29, 2021

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

github-actions bot Feb 2, 2021

Choose a reason for hiding this comment

github-actions bot Feb 2, 2021

Choose a reason for hiding this comment

github-actions bot Feb 2, 2021

Choose a reason for hiding this comment

kpango commented Jan 29, 2021 •

edited

Loading

vdaas-ci commented Jan 29, 2021 •

edited by kpango

Loading

hlts2 left a comment •

edited

Loading

kpango commented Jan 29, 2021 •

edited

Loading

kpango commented Jan 29, 2021 •

edited

Loading