Add test case for internal/errors/mysql.go #918

hlts2 · 2021-01-13T01:51:07Z

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I added the test cases for internal/errors/mysql.go and comments.
And I fixed the test error for parallel testing and existing code to support parallel testing.

Details of fails test

goroutine detecting error occurs when we use t.Parallel and goleak.Verity(tt) in the sub-test.
the goroutine generated by t.Parallel will also be detected by goleak.
So I Changed to use goleak.IgnoreCurrent method and ignore goroutines other than the function under test

grammar check passed

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.2
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

codecov · 2021-01-13T02:07:12Z

Codecov Report

Merging #918 (7e07d2a) into master (fa77790) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
+ Coverage   16.08%   16.15%   +0.06%     
==========================================
  Files         476      476              
  Lines       23839    23839              
==========================================
+ Hits         3835     3851      +16     
+ Misses      19763    19748      -15     
+ Partials      241      240       -1

Impacted Files	Coverage Δ
internal/errors/mysql.go	`100.00% <ø> (+100.00%)`	⬆️
internal/errgroup/group.go	`92.42% <0.00%> (-1.52%)`	⬇️
internal/worker/worker.go	`83.33% <0.00%> (-1.05%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153f8d0...7e07d2a. Read the comment docs.

internal/errors/mysql_test.go

vankichi

LGTM

kevindiu · 2021-01-21T04:24:08Z

/rebase

vdaas-ci · 2021-01-21T04:24:45Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-errors-mysql-test

kevindiu · 2021-01-25T02:42:04Z

/rebase

vdaas-ci · 2021-01-25T02:42:40Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-errors-mysql-test

kevindiu · 2021-01-25T02:49:29Z

/format
/rebase
/approve

vdaas-ci · 2021-01-25T02:50:10Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-errors-mysql-test

vdaas-ci · 2021-01-25T02:51:01Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

kevindiu

LGTM

kevindiu · 2021-01-25T02:57:26Z

/format
/rebase
/approve

vdaas-ci · 2021-01-25T02:58:00Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-errors-mysql-test

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

vdaas-ci · 2021-01-25T02:58:54Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

* feat: add test case and comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add godoc comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Apply suggestions from code review * fix: goleak bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: fails test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update internal/errors/mysql_test.go * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Signed-off-by: kpango <kpango@vdaas.org>

hlts2 force-pushed the test/internal/add-errors-mysql-test branch from 6a50c45 to 6546fdb Compare January 13, 2021 01:52

github-actions bot added area/internal team/set SET team size/XL type/test Adding tests priority/low labels Jan 13, 2021

hlts2 commented Jan 13, 2021

View reviewed changes

hlts2 commented Jan 18, 2021

View reviewed changes

internal/errors/mysql_test.go Outdated Show resolved Hide resolved

hlts2 requested a review from vankichi January 18, 2021 03:33

hlts2 changed the title ~~[WIP] Add test case for internal/errors/mysql.go~~ Add test case for internal/errors/mysql.go Jan 19, 2021

hlts2 self-assigned this Jan 19, 2021

vankichi reviewed Jan 21, 2021

View reviewed changes

vankichi previously approved these changes Jan 21, 2021

View reviewed changes

vdaas-ci dismissed vankichi’s stale review via 301019b January 21, 2021 04:24

vdaas-ci force-pushed the test/internal/add-errors-mysql-test branch from 65ef545 to 301019b Compare January 21, 2021 04:24

hlts2 requested a review from kevindiu January 25, 2021 01:31

vdaas-ci force-pushed the test/internal/add-errors-mysql-test branch from 301019b to 438a29c Compare January 25, 2021 02:42

kevindiu previously approved these changes Jan 25, 2021

View reviewed changes

hlts2 added 2 commits January 25, 2021 02:58

feat: add test case and comment

6479dad

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: add godoc comment

2a7b5ce

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

hlts2 and others added 5 commits January 25, 2021 02:58

Apply suggestions from code review

d20904f

fix: goleak bug

1132bc6

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: fails test

3f1d003

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

Update internal/errors/mysql_test.go

db569e6

Apply suggestions from code review

7e07d2a

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

vdaas-ci dismissed kevindiu’s stale review via 7e07d2a January 25, 2021 02:58

vdaas-ci force-pushed the test/internal/add-errors-mysql-test branch from 438a29c to 7e07d2a Compare January 25, 2021 02:58

kevindiu merged commit 5df9ec1 into master Jan 25, 2021

kevindiu deleted the test/internal/add-errors-mysql-test branch January 25, 2021 03:14

vdaas-ci mentioned this pull request Jan 29, 2021

Bug fix for gateway #963

Merged

18 tasks

kpango mentioned this pull request Feb 2, 2021

[major] v1.0.0 Release #974

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test case for internal/errors/mysql.go #918

Add test case for internal/errors/mysql.go #918

hlts2 commented Jan 13, 2021 •

edited

Loading

codecov bot commented Jan 13, 2021 •

edited

Loading

vankichi left a comment

kevindiu commented Jan 21, 2021

vdaas-ci commented Jan 21, 2021

kevindiu commented Jan 25, 2021

vdaas-ci commented Jan 25, 2021

kevindiu commented Jan 25, 2021

vdaas-ci commented Jan 25, 2021

vdaas-ci commented Jan 25, 2021

kevindiu left a comment

kevindiu commented Jan 25, 2021

vdaas-ci commented Jan 25, 2021

vdaas-ci commented Jan 25, 2021

Add test case for internal/errors/mysql.go #918

Add test case for internal/errors/mysql.go #918

Conversation

hlts2 commented Jan 13, 2021 • edited Loading

Description:

Details of fails test

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

codecov bot commented Jan 13, 2021 • edited Loading

Codecov Report

vankichi left a comment

Choose a reason for hiding this comment

kevindiu commented Jan 21, 2021

vdaas-ci commented Jan 21, 2021

kevindiu commented Jan 25, 2021

vdaas-ci commented Jan 25, 2021

kevindiu commented Jan 25, 2021

vdaas-ci commented Jan 25, 2021

vdaas-ci commented Jan 25, 2021

kevindiu left a comment

Choose a reason for hiding this comment

kevindiu commented Jan 25, 2021

vdaas-ci commented Jan 25, 2021

vdaas-ci commented Jan 25, 2021

hlts2 commented Jan 13, 2021 •

edited

Loading

codecov bot commented Jan 13, 2021 •

edited

Loading