-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid data loading code in example #949
Conversation
[CHATOPS:HELP] ChatOps commands.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this code depend on the data set?
I remember that it was the SET team that wrote the example, but I think SET was verifying the behavior at the time.
@vankichi can you explain the situation a bit?
On a completely unrelated note, I really like this code in the hdf5 library |
Yes it does. For fashion mnist, float32 is correct. |
I think SET team didn't check whether the loaded value is correct or not. Maybe they checked just only whether the example code works or not. |
hmm, I see but this example code can be overwrite dataset path variable by cli argument so could you please add about comment for the users and also could you please add comment to the docs? |
BTW how can we verify if the loaded data is correct or not? |
Sure. I'll revise it. @kpango Using HDFView (https://www.hdfgroup.org/downloads/hdfview/), you can see the correct values of the data. @kevindiu |
957c0db
to
068fb26
Compare
I've added comments about the HDF5 datatype on the examples codes. Since there's no section about the using dataset in the Getting Started, I didn't edit it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
I fixed the invalid data loading code in example/main.go.
I've already mentioned about it a month ago, but it's not fixed yet.
https://github.com/vdaas/vald/projects/4#card-51586276
HDF5 formatted data of fashion-mnist has its data as float32 values. So it should be loaded as float32.
Related Issue:
nothing
How Has This Been Tested?:
nothing
Environment:
Types of changes:
Changes to Core Features:
Checklist: