Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change grpc bidi-stream error handling and change grpc API interface #928

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jan 14, 2021

Signed-off-by: kpango kpango@vdaas.org

Description:

change grpc bidi-stream error handling and change grpc API interface for more informative payload for each stream response

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

…for more informative payload for each stream response

Signed-off-by: kpango <kpango@vdaas.org>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #928 (22c11b2) into master (a43f8f7) will increase coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
+ Coverage   16.20%   16.30%   +0.10%     
==========================================
  Files         472      470       -2     
  Lines       23158    23075      -83     
==========================================
+ Hits         3752     3763      +11     
+ Misses      19171    19072      -99     
- Partials      235      240       +5     
Impacted Files Coverage Δ
internal/net/grpc/addrs.go 0.00% <0.00%> (ø)
internal/net/grpc/status/status.go 0.00% <0.00%> (ø)
internal/net/grpc/stream.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/gateway/backup/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/gateway/lb/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/gateway/meta/handler/grpc/handler.go 0.00% <0.00%> (ø)
internal/db/storage/blob/s3/reader/reader.go 63.04% <0.00%> (-31.53%) ⬇️
internal/worker/queue.go 95.00% <0.00%> (-5.00%) ⬇️
internal/errgroup/group.go 92.42% <0.00%> (-1.52%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73dde2e...1cb39aa. Read the comment docs.

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the feature/apis-internal/change-grpc-bidirectional-stream-error-handling-and-api-interfaces branch from 6da7b75 to 87fe2a7 Compare January 14, 2021 08:40
Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: kpango <kpango@vdaas.org>
@github-actions github-actions bot added the team/set SET team label Jan 14, 2021
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango changed the title [WIP] change grpc bidi-stream error handling and change grpc API interface change grpc bidi-stream error handling and change grpc API interface Jan 15, 2021
@kpango kpango merged commit 2990012 into master Jan 15, 2021
@kpango kpango deleted the feature/apis-internal/change-grpc-bidirectional-stream-error-handling-and-api-interfaces branch January 15, 2021 02:28
@vdaas-ci vdaas-ci mentioned this pull request Jan 29, 2021
18 tasks
@kpango kpango mentioned this pull request Feb 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants