-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change grpc bidi-stream error handling and change grpc API interface #928
Merged
kpango
merged 5 commits into
master
from
feature/apis-internal/change-grpc-bidirectional-stream-error-handling-and-api-interfaces
Jan 15, 2021
Merged
change grpc bidi-stream error handling and change grpc API interface #928
kpango
merged 5 commits into
master
from
feature/apis-internal/change-grpc-bidirectional-stream-error-handling-and-api-interfaces
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for more informative payload for each stream response Signed-off-by: kpango <kpango@vdaas.org>
github-actions
bot
added
area/gateway
area/gateway/backup
area/gateway/filter
area/gateway/lb
area/gateway/meta
area/internal
size/L
type/feature
New feature
labels
Jan 14, 2021
[CHATOPS:HELP] ChatOps commands.
|
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
+ Coverage 16.20% 16.30% +0.10%
==========================================
Files 472 470 -2
Lines 23158 23075 -83
==========================================
+ Hits 3752 3763 +11
+ Misses 19171 19072 -99
- Partials 235 240 +5
Continue to review full report at Codecov.
|
rinx
reviewed
Jan 14, 2021
Signed-off-by: kpango <kpango@vdaas.org>
kpango
force-pushed
the
feature/apis-internal/change-grpc-bidirectional-stream-error-handling-and-api-interfaces
branch
from
January 14, 2021 08:40
6da7b75
to
87fe2a7
Compare
Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: kpango <kpango@vdaas.org>
kpango
changed the title
[WIP] change grpc bidi-stream error handling and change grpc API interface
change grpc bidi-stream error handling and change grpc API interface
Jan 15, 2021
kpango
deleted the
feature/apis-internal/change-grpc-bidirectional-stream-error-handling-and-api-interfaces
branch
January 15, 2021 02:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kpango kpango@vdaas.org
Description:
change grpc bidi-stream error handling and change grpc API interface for more informative payload for each stream response
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: