Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for internal/errors/http.go #908

Merged
merged 6 commits into from
Jan 19, 2021

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Jan 6, 2021

Description:

I added the test cases for internal/errors/http.go and comments.

grammar check passed

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@hlts2 hlts2 self-assigned this Jan 6, 2021
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jan 6, 2021

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #908 (0735716) into master (5c914a2) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   16.31%   16.35%   +0.03%     
==========================================
  Files         469      469              
  Lines       23033    23033              
==========================================
+ Hits         3758     3767       +9     
+ Misses      19041    19032       -9     
  Partials      234      234              
Impacted Files Coverage Δ
internal/errors/http.go 100.00% <ø> (+100.00%) ⬆️
internal/worker/worker.go 81.25% <0.00%> (-2.09%) ⬇️
internal/worker/queue.go 98.33% <0.00%> (-1.67%) ⬇️
internal/errgroup/group.go 93.93% <0.00%> (+1.51%) ⬆️
internal/errors/errors.go 35.93% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09d062...d1aaf82. Read the comment docs.

internal/errors/http_test.go Outdated Show resolved Hide resolved
internal/errors/http_test.go Outdated Show resolved Hide resolved
internal/errors/http_test.go Outdated Show resolved Hide resolved
internal/errors/http_test.go Outdated Show resolved Hide resolved
internal/errors/http_test.go Outdated Show resolved Hide resolved
internal/errors/http_test.go Outdated Show resolved Hide resolved
internal/errors/http_test.go Outdated Show resolved Hide resolved
internal/errors/http_test.go Outdated Show resolved Hide resolved
internal/errors/http_test.go Outdated Show resolved Hide resolved
internal/errors/http_test.go Outdated Show resolved Hide resolved
@hlts2 hlts2 changed the title [WIP] Add test case for internal/errors/http.go Add test case for internal/errors/http.go Jan 6, 2021
@hlts2 hlts2 requested a review from vankichi January 6, 2021 09:45
internal/errors/http.go Show resolved Hide resolved
internal/errors/http.go Show resolved Hide resolved
vankichi
vankichi previously approved these changes Jan 12, 2021
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi
vankichi previously approved these changes Jan 18, 2021
kevindiu
kevindiu previously approved these changes Jan 19, 2021
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-errors-http-test

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci vdaas-ci dismissed stale reviews from kevindiu and vankichi via ff290f9 January 19, 2021 01:06
@vdaas-ci vdaas-ci force-pushed the test/internal/add-errors-http-test branch from 1fe08b7 to ff290f9 Compare January 19, 2021 01:06
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

@kevindiu kevindiu merged commit 0f0cc06 into master Jan 19, 2021
@kevindiu kevindiu deleted the test/internal/add-errors-http-test branch January 19, 2021 01:20
@vdaas-ci vdaas-ci mentioned this pull request Jan 29, 2021
18 tasks
@kpango kpango mentioned this pull request Feb 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants