Remove actions/cache to improve workflow speed / Refactoring docker-build workflows

[rinx]

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

• Removed cache docker layers step from docker build workflows because it doesn't make builds so faster.

For agent-ngt builds,

layer cache	platforms	duration	log
without	amd64	4m38s	https://github.com/vdaas/vald/actions/runs/513797778
without	amd64, arm64	24m0s	https://github.com/vdaas/vald/actions/runs/513821869
with (first time)	amd64	7m2s	https://github.com/vdaas/vald/actions/runs/513884200
with (first time)	amd64, arm64	23m55s	https://github.com/vdaas/vald/actions/runs/513922698
with (second time)	amd64	4m8s	https://github.com/vdaas/vald/actions/runs/513900837
with (second time)	amd64, arm64	17m13s	https://github.com/vdaas/vald/actions/runs/513966632

• Added internal action template for docker build workflows.

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

• Go Version: 1.15.7
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.13.1

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[rinx]

The new workflow runs like:

• https://github.com/vdaas/vald/actions/runs/514567231
• https://github.com/vdaas/vald/actions/runs/514567229
• https://github.com/vdaas/vald/actions/runs/514567228

[kpango]

Looks excellent to me.
I have 1 question, can we remove golang-busert dependency from docker containers?
I mean can we use base's golang binary ?

[rinx]

Thanks for reviewing.
As I told to you before, if we remove the golang:buster image from the each Dockerfiles, when the GO_VERSION file is updated, the newer version is not reflected at the first build of the PR. It is a risk of that removal.
We can write a shell script such as wait-for-base-build, but it will take few more minutes to build each image.
So the current Dockerfiles and workflows are the safer and faster way of building, I think.