Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on updating status of VR & VHOR resources #892

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Dec 17, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

There was a bug on updating ValdRelease & ValdHelmOperatorRelease resources by vald-helm-operator.
The cause is that there were no status field in the CRDs.
In this PR, I added status fields in the CRDs.

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@rinx rinx force-pushed the bugfix/helm-operator/add-subresource-status-field branch 3 times, most recently from ea37828 to 551813e Compare December 22, 2020 02:54
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the bugfix/helm-operator/add-subresource-status-field branch from 551813e to fac373e Compare December 22, 2020 07:44
@kpango kpango merged commit 162b641 into master Dec 24, 2020
@kpango kpango deleted the bugfix/helm-operator/add-subresource-status-field branch December 24, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants