Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Rename PriorityClass objects to contain namespace #901

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Dec 24, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

SSIA

Related Issue:

Nothing

How Has This Been Tested?:

Nothing

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@rinx rinx requested a review from kpango December 24, 2020 02:02
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

kpango
kpango previously approved these changes Dec 24, 2020
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
could you please release it as patch version?

@rinx
Copy link
Contributor Author

rinx commented Dec 24, 2020

@kpango thanks for your review.
Could I release #892 in the same patch version?

@kpango
Copy link
Collaborator

kpango commented Dec 24, 2020

sounds good, I'm checking into it.

@rinx rinx changed the title Rename PriorityClass objects to contain namespace [patch] Rename PriorityClass objects to contain namespace Dec 24, 2020
@rinx
Copy link
Contributor Author

rinx commented Dec 24, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by rinx for branch: refactor/helm-charts/use-namespaced-priorityclass

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@github-actions github-actions bot force-pushed the refactor/helm-charts/use-namespaced-priorityclass branch from 47eab08 to 93e0e63 Compare December 24, 2020 02:14
@rinx rinx merged commit 3544ade into master Dec 24, 2020
@rinx rinx deleted the refactor/helm-charts/use-namespaced-priorityclass branch December 24, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants