-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] Happy new year #905
Conversation
[CHATOPS:HELP] ChatOps commands.
|
@@ -159,9 +165,12 @@ func readAndRewrite(path string) error { | |||
return errors.Errorf("filepath %s, could not open", path) | |||
} | |||
buf := bytes.NewBuffer(make([]byte, 0, fi.Size())) | |||
maintainer := os.Getenv(maintainerKey) | |||
if len(maintainer) == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci] reported by reviewdog 🐶
only one cuddle assignment allowed before if statement (wsl)
89c3911
to
9534d51
Compare
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
==========================================
- Coverage 19.16% 19.12% -0.05%
==========================================
Files 423 422 -1
Lines 19600 19548 -52
==========================================
- Hits 3756 3738 -18
+ Misses 15627 15601 -26
+ Partials 217 209 -8
Continue to review full report at Codecov.
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HAPPY NEW YEAR 🎉
Signed-off-by: kpango <kpango@vdaas.org>
9534d51
to
e42e893
Compare
Signed-off-by: kpango <kpango@vdaas.org>
245716e
to
e7b6132
Compare
Signed-off-by: kpango kpango@vdaas.org
Description:
Happy new year!!
I updated license.
each docker files start to use MAINTAINER ARG value to set container maintainers.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: