Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Happy new year #905

Merged
merged 2 commits into from
Jan 1, 2021
Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Dec 31, 2020

Signed-off-by: kpango kpango@vdaas.org

Description:

Happy new year!!
I updated license.
each docker files start to use MAINTAINER ARG value to set container maintainers.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@kpango kpango changed the title Happy new yeargit diff [patch] Happy new year Dec 31, 2020
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@@ -159,9 +165,12 @@ func readAndRewrite(path string) error {
return errors.Errorf("filepath %s, could not open", path)
}
buf := bytes.NewBuffer(make([]byte, 0, fi.Size()))
maintainer := os.Getenv(maintainerKey)
if len(maintainer) == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci] reported by reviewdog 🐶
only one cuddle assignment allowed before if statement (wsl)

@kpango kpango force-pushed the feature/license/happy-new-year-2021 branch from 89c3911 to 9534d51 Compare December 31, 2020 15:14
@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #905 (e7b6132) into master (ab1ec89) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   19.16%   19.12%   -0.05%     
==========================================
  Files         423      422       -1     
  Lines       19600    19548      -52     
==========================================
- Hits         3756     3738      -18     
+ Misses      15627    15601      -26     
+ Partials      217      209       -8     
Impacted Files Coverage Δ
cmd/agent/core/ngt/main.go 0.00% <ø> (ø)
cmd/agent/sidecar/main.go 0.00% <ø> (ø)
cmd/discoverer/k8s/main.go 0.00% <ø> (ø)
cmd/gateway/vald/main.go 0.00% <ø> (ø)
cmd/manager/backup/cassandra/main.go 0.00% <ø> (ø)
cmd/manager/backup/mysql/main.go 0.00% <ø> (ø)
cmd/manager/compressor/main.go 0.00% <ø> (ø)
cmd/manager/index/main.go 0.00% <ø> (ø)
cmd/manager/replication/agent/main.go 0.00% <ø> (ø)
cmd/manager/replication/controller/main.go 0.00% <ø> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1ec89...e7b6132. Read the comment docs.

@kevindiu
Copy link
Contributor

LGTM

vankichi
vankichi previously approved these changes Dec 31, 2020
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAPPY NEW YEAR 🎉

Signed-off-by: kpango <kpango@vdaas.org>
Makefile Show resolved Hide resolved
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the feature/license/happy-new-year-2021 branch from 245716e to e7b6132 Compare January 1, 2021 09:57
@kpango kpango merged commit 5b8cfad into master Jan 1, 2021
@kpango kpango deleted the feature/license/happy-new-year-2021 branch January 1, 2021 11:30
@rinx rinx mentioned this pull request Jan 6, 2021
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants