Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license headers for .github yamls #907

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jan 6, 2021

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

The files under the .github directory are forgot to update in #905.

  • Revise Makefile task to run license/gen/main.go for .github files.
  • Add license headers for .github files.

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jan 6, 2021

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #907 (56d2f53) into master (c4df6ef) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
+ Coverage   19.19%   19.20%   +0.01%     
==========================================
  Files         422      422              
  Lines       19548    19548              
==========================================
+ Hits         3752     3754       +2     
+ Misses      15586    15585       -1     
+ Partials      210      209       -1     
Impacted Files Coverage Δ
internal/errgroup/group.go 92.42% <0.00%> (-1.52%) ⬇️
internal/worker/worker.go 82.29% <0.00%> (+1.04%) ⬆️
internal/worker/queue.go 98.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4df6ef...944d47f. Read the comment docs.

@rinx rinx mentioned this pull request Jan 7, 2021
18 tasks
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -260,6 +260,7 @@ clean:
license:
MAINTAINER=$(MAINTAINER) \
go run hack/license/gen/main.go ./
go run hack/license/gen/main.go .github
Copy link
Collaborator

@kpango kpango Jan 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kpango kpango merged commit b8911ac into master Jan 11, 2021
@kpango kpango deleted the refactor/makefile/update-license-of-github-dir branch January 11, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants