Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor: using only viem for EIP712" #1547

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

freemanzMrojo
Copy link
Member

@freemanzMrojo freemanzMrojo commented Nov 29, 2024

Reverts #1516 while waiting for this issue to be clarified wevm/abitype#256

Copy link

github-actions bot commented Nov 29, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
99% (4368/4412) 97.56% (1400/1435) 99.01% (906/915)
Title Tests Skipped Failures Errors Time
core 836 0 💤 0 ❌ 0 🔥 2m 20s ⏱️
network 727 0 💤 0 ❌ 0 🔥 4m 47s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 17.341s ⏱️
logging 3 0 💤 0 ❌ 0 🔥 18.339s ⏱️
hardhat-plugin 19 0 💤 0 ❌ 0 🔥 57.997s ⏱️
aws-kms-adapter 23 0 💤 0 ❌ 0 🔥 1m 13s ⏱️
ethers-adapter 5 0 💤 0 ❌ 0 🔥 1m 13s ⏱️
rpc-proxy 37 0 💤 0 ❌ 0 🔥 1m 1s ⏱️

@freemanzMrojo freemanzMrojo marked this pull request as ready for review November 29, 2024 10:24
@freemanzMrojo freemanzMrojo requested a review from a team as a code owner November 29, 2024 10:24
@victhorbi victhorbi added this to the v1.0.0-RC4 milestone Nov 29, 2024
@victhorbi victhorbi requested a review from a team November 29, 2024 10:35
@freemanzMrojo freemanzMrojo merged commit b8e5a35 into main Nov 29, 2024
16 checks passed
@freemanzMrojo freemanzMrojo deleted the revert-1516-refactor/using-only-viem-kms-adapter branch November 29, 2024 10:46
GrandinLuc added a commit that referenced this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants