Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SP2: Adding Rooms to Spaces #5230

Closed
2 tasks done
Tracked by #16
nadonomy opened this issue Dec 1, 2021 · 5 comments
Closed
2 tasks done
Tracked by #16

SP2: Adding Rooms to Spaces #5230

nadonomy opened this issue Dec 1, 2021 · 5 comments
Assignees
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Dec 1, 2021

Your use case

Part of a larger project to implement Space creation & Space management on iOS.

Tasks

[Figma]

  • Implement designs with new & existing tabs in a bottom sheet
  • Replace rough edge warnings from space panel overflow with working journeys
@nadonomy nadonomy added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Spaces Spaces, groups, communities labels Dec 1, 2021
@niquewoodhouse niquewoodhouse added S-Critical Prevents work, causes data loss and/or has no workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 14, 2022
@gileluard
Copy link
Contributor

We are missing some use cases in explore rooms screen:

  • the user power level is not high enough to send state events for the parent room: the Add room row should be disabled or a popup should be displayed (message needed)
  • The parent room is not joined: We could remove the Add room row but I'd personally replace it by a Join space row (icon needed)
    Simulator Screen Shot - iPhone 12 Pro - 2022-01-17 at 16 10 41

Also we have the same issue with the Create room option in the home screen:
Simulator Screen Shot - iPhone 12 Pro - 2022-01-17 at 16 39 39

@niquewoodhouse
Copy link

niquewoodhouse commented Jan 17, 2022

the user power level is not high enough to send state events for the parent room: the Add room row should be disabled or a popup should be displayed (message needed)

I think it would be best for the user to not disable or hide and show the pop up idea. Because the user can become get the rights to add rooms if someone promotes them, I believe it is useful to inform them via the pop up that they can't do that right now, but a space admin can enable them if they ask.

The parent room is not joined: We could remove the Add room row but I'd personally replace it by a Join space row (icon needed)

Parent room = parent space? I'd suggest putting it in the header where cancel is and moving cancel to the left side. If they're in a subpsace, cancel can them become a < back.

Example:

image

@gileluard
Copy link
Contributor

The first case cannot happen as the explore room feature is available only for joined spaces in the application (UX wise).

I think it will be confusing for the users:

  • the space has been joined the user will see that:
    Untitled

  • the space is not joined the user will see that:
    Untitled

The Add row is very confusing in the second case in my opinion

@niquewoodhouse
Copy link

  • Lets remove the add row in the second case.

the space has been joined the user will see that:

Is the concern here that you have cancel in top right and chevon in left?

@niquewoodhouse
Copy link

In a DM myself and @gileluard discussed some alternatives

  • Using the Create new room cta area to Join space:

  • Using the Add room list item as suggested here

We decided to proceed with this suggestion and test it because we're not super confident it works (people might not see Join)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

3 participants