-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn users if markdown is going to kick-in on their message, and give a nice UI for disabling it if desired #1189
Comments
I haven't ever felt the need for this feature in a RT/MD composer world. Do we still want it? |
/me raises lampholder's question again: do we still want/need this? |
please have options to disable markdown, perhaps in the settings there can be a option to choose which to defaults to, and have both /plain and /md for temporary choosing one |
I would also greatly appreciate having a way to disable Markdown besides A lot of the time I don't need it, I do need to type a literal *, and putting |
The default input method on RiotX (Android) also seems to be plain text only. |
Ah, my bad, the Markdown formatting is behind a preference option on RiotX, but I had disabled it long ago. |
I really have a hard time sometimes with Riot.... I type long messages frequently, and sometimes put multiple line breaks to separate paragraphs, for better understanding. I still cannot understand what exactly decides whether all multiple line breaks will be ignored or not (converting into 1 line break with a slight margin between paragraphs). Sometimes I'm forced to put dots "." in every line break, to make sure the spacing that I want is respected. Seriously.... please stop Riot being obtrusive in the way we type. Also, I think it's really not good that Riot actually makes replacements to my original text. -- After reading this thread, I'm aware now that I can use the "/plain" command.
|
Thanks! Can I just confirm with you what will this setting do?
or
|
@nunoperalta it just disables any and all Markdown you send. For example,
I could change the message to "Format your messages with Markdown"? Anyway, HMU in #element-dev:matrix.org (happy to chat and explain) or the PR if you have any more questions :-) |
Perfect! That's exactly what I'm looking for here :)
This would likely clear any ambiguity! It would be better, in my opinion. Thanks! |
Related to #16304 (comment) |
Just add a toggle to switch between the two modes please as mentioned in element-hq/element-web#17401 |
This, and "mark as unread", are currently the most important features my team are missing. |
This comment is response to http://github.com/vector-im/element-web/issues/483#issuecomment-844325462 and http://github.com/vector-im/element-web/issues/483#issuecomment-716231528. "/plain" and "/html" are present, so this should be implemented as a toggle. Instead of that, it should be implemented as a combination-box when choosing the default. |
Don't care how it's done but please add the option of not screwing up the things I type. It's really really annoying if you have to type anything "technical". Like even the simplest "+ 1" is rendered as a bullet point. However if you try to edit it to put everything into a ``` block or something you'll discover it has been modified to be "- 1"! Basically you can't trust Element to transmit/save what was actually typed. Horrible. |
@kilx you're collating multiple issues at once, the +1 thing is because commonmark (the markdown engine element uses) is interpreting those as bullet points, #330 deals with switching over to github-flavoured-commonmark, which'd help this issue. The "transmit/save what was actually typed" bit is because element has to convert that markdown to HTML, another format which displays things easier, but then it is harder to extract the original bits and pieces of what's typed from that, because specific things such as "did this bullet point get made with a It's not nice all around, but its just the limits of the current system. |
Ok, it's always more complicated than it looks. However the "disable markdown, just let me use plain text" option would still solve all these issues from my point of view. The "+ 1" was just the smallest example I could think of. Thanks for replying! |
Element iOS has this option, and I'm kinda surprised that element web doesn't as well. While some likewise issues were closed as duplicates to this, i think that's an entirely seperate issue, let me open it. Edit: created element-hq/element-web#20321 |
There might be some ongoing work with the composer design that could impact the best way to show a UI for disabling md in the composer, so I'd rather not look at this specific interaction until its more clear what's happening with that work. For now, I believe element-hq/element-web#20321 is a good solution - I added a comment with a suggested design |
@niquewoodhouse in that case should we close this issue in favour of element-hq/element-web#20321 ? |
This was originally element-hq/element-web#439.
Conversely, we could warn the user that their message contains markdown, and they should turn it on when desired.
UI-wise... um.... this could be a toggleable plinth that appears at the RHS of the input box? Or at the RHS of the the status area above the input box? The latter is probably nicest. We probably want regexp-based heuristics to guess about presence of markdown rather than to run markdown on the message every time you press a key.
The text was updated successfully, but these errors were encountered: