-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci)!: Update tested Kubernetes versions #7798
chore(ci)!: Update tested Kubernetes versions #7798
Conversation
Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the docs with this change too? 👍 on supporting only the lowest available version on major cloud providers.
I wasn't sure if we wanted to - the chart still works on 1.14, we're no longer testing - I think it's a good idea to tighten the scope of supported versions, but that's also a larger discussion and (possibly) impactful to users/customers |
I'd say we need to update the docs. If we aren't testing it, we aren't supporting it. |
I'd defer to the group/leadership, but there's definitely some semantics here - Vector is still compatible with 1.14, we're not testing it actively, but we're also "best effort" not breaking existing compatibilities. Perhaps we could adopt language similar to minikube's:
|
I'm inclined to agree with this. If we aren't testing it, we aren't really supporting it. My preference would be to support the lowest common denominator version for the major cloud providers. I do think we should update the docs with this PR. |
👍
I think can figure this out in a following issue/rfc
I'll just update the docs to be |
Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
Yeah, this is a good question. I guess technically it should be a breaking change. I'd like to have us define a policy for what is breaking and not. I'll make a note of this for next quarter. |
I'll update it to be a breaking change, and I'll fix these patch versions - I went a little too new for these patches, I think the failing ones are to be released next week 😅 |
Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
Tested the two failed jobs locally and they passed, so I'm guessing just flakey? Or maybe related to the runner env |
I have a hunch about that flakey test. It's not to do with this PR. By creating the affinity pod in the same namespace as the test pod, sometimes the test picks up the logs from that pod instead. I'll get a fix. |
Talked a bit over slack we have two sources of flakiness here, cri-o related and one in our tests @StephenWakely will fix |
Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
Signed-off-by: Spencer Gilbert spencer.gilbert@gmail.com
While Vector still runs on kubernetes 1.14.x, as far as I can tell it's no longer offered/supported
by any major cloud provider. Right now #6564 is failing CI as we try to use a kubectl command that isn't
supported in 1.14.x (
rollout restart
).This PR does the following:
I'd also suggest consider adjusting our documentation around required/supported kubernetes versions. We'll also need to update and include more versions in a followup