enhancement(tests): Create affinity pod in separate namespace for k8s tests #7831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenWakely
added
ci-condition: k8s e2e all targets
StephenWakely
changed the title
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
StephenWakely
force-pushed
the
affinity_namespace
branch
from
b356ac9 to
8813a10
Compare
spencergilbert
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #7798 there is the potential for flakiness in tests.
Some tests create a pod purely for the purpose of other tests to have affinity to to ensure they are all deployed on the same node. However these tests also scan the logs for any pods in a given namespace to test various things. If the affinity pod is created in this namespace there is the potential for any logs they create to interfere with the tests.
This PR creates these affinity pods in a separate namespace so they don't have the risk of getting in the way.
Signed-off-by: Stephen Wakely fungus.humungus@gmail.com