Use potentiometer for angle offset calib #760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitenntaisei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I want to use potentiometer to calibrate Position PID Offset Angle in my servo because the position accuracy of hall sensor is not enough for me. I believe there are some people who also need this feature, since using potentiometer as a position measurement tool is common.
Detail
I use ADC1 as the potentiometer voltage input, because ADC2 might be used as a brake. I just linear mapped voltage to angle and I put moving average filter in order to erase the noise. This feature can be toggled by newly added
MCCONF_P_PID_POT_OFFSET_CALIB.Impact
vedderb/vesc_tool#380 is needed for signature matching, though feature would be off in the default.
TEST
I tested this PR on SUPERFOC6.8 and everything worked as I expected.