Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix wording in docs #8466

Merged
merged 4 commits into from
Feb 12, 2023
Merged

docs: fix wording in docs #8466

merged 4 commits into from
Feb 12, 2023

Conversation

rgkirch
Copy link
Contributor

@rgkirch rgkirch commented Oct 10, 2022

Improve wording

site/docs/mark/tick.md Outdated Show resolved Hide resolved
@domoritz
Copy link
Member

Can you please use semantic messages for the pull request title and include some more details about the change (like a screenshot of the current page)?

Co-authored-by: Dominik Moritz <domoritz@gmail.com>
@rgkirch
Copy link
Contributor Author

rgkirch commented Oct 11, 2022

image

@rgkirch rgkirch changed the title Update tick.md fix wording in docs Oct 11, 2022
@domoritz domoritz changed the title fix wording in docs docs: fix wording in docs Oct 11, 2022
@domoritz
Copy link
Member

The second one shows the distribution broken down by number of cylinders. I think the proposed wording is confusing since the chart doesn't show the distribution per car.

site/docs/mark/tick.md Outdated Show resolved Hide resolved
@domoritz domoritz merged commit 9861197 into vega:next Feb 12, 2023
@vega-org-bot
Copy link
Collaborator

🚀 PR was released in v5.7.0-next.0 🚀

@rgkirch rgkirch deleted the patch-1 branch February 13, 2023 13:07
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
* Update tick.md

* Update tick.md

* Update site/docs/mark/tick.md

Co-authored-by: Dominik Moritz <domoritz@gmail.com>

* Update site/docs/mark/tick.md

---------

Co-authored-by: Dominik Moritz <domoritz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants