Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use any mark config for composite mark components #8145

Merged
merged 2 commits into from
Feb 12, 2023
Merged

feat: use any mark config for composite mark components #8145

merged 2 commits into from
Feb 12, 2023

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented May 6, 2022 •
edited by vega-org-bot
Loading

fixes #8144

📦 Published PR as canary version: 5.7.0--canary.8145.0eb1af7.0

✨ Test out this PR locally via:

npm install vega-lite@5.7.0--canary.8145.0eb1af7.0
# or 
yarn add vega-lite@5.7.0--canary.8145.0eb1af7.0

Version

Published prerelease version: v5.7.0-next.0

Changelog

🎉 This release contains work from new contributors! 🎉

Thanks for all your work!

❤️ null@rgkirch

❤️ null@schmoigl

❤️ Fractal Banana (@ObservedObserver)

❤️ null@PBI-David

❤️ Emery Berger (@emeryberger)

❤️ Frédéric Collonval (@fcollonval)

🚀 Enhancement

  • feat: use any mark config for composite mark components #8145 (@domoritz)

🐛 Bug Fix

Authors: 9

@domoritz
Copy link
Member Author

domoritz commented May 6, 2022

cc @joelostblom

@domoritz domoritz requested a review from kanitw May 6, 2022 18:49
@domoritz domoritz mentioned this pull request May 6, 2022
Closed
@domoritz domoritz requested a review from a team February 12, 2023 19:34
@domoritz
Copy link
Member Author

Merging since it fixes an issue. @kanitw @arvind happy to change things in a follow up pull request.

@domoritz domoritz merged commit 67c44e3 into next Feb 12, 2023
@domoritz domoritz deleted the dom/props branch February 12, 2023 19:35
@vega-org-bot
Copy link
Collaborator

🚀 PR was released in v5.7.0-next.0 🚀

BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
@domoritz @BradyJ27
feat: use any mark config for composite mark components (vega#8145)
cf569c3 
fixes vega#8144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanitw kanitw Awaiting requested review from kanitw

Assignees
No one assigned
Labels
prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boxplot's median tick thickness not in mark definition?
2 participants
@domoritz @vega-org-bot