fix: constrain isConditionalParameter type parameter
#8473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @fcollonval! |
5 tasks
|
@domoritz just curious if you were able to have a look at this PR? Thanks! |
jtpio
added a commit
to jtpio/jupyterlab
that referenced
this pull request
Dec 1, 2022
Skip lib check for now while waiting for vega/vega-lite#8473 See the discussion in jupyterlab#13028 for more information
domoritz
changed the title
isConditionalParameter type parameterisConditionalParameter type parameter
|
Thank you for the pull request and your patience! |
|
Thanks @domoritz! |
jtpio
added a commit
to jtpio/jupyterlab
that referenced
this pull request
Dec 19, 2022
Skip lib check for now while waiting for vega/vega-lite#8473 See the discussion in jupyterlab#13028 for more information
jtpio
added a commit
to jtpio/jupyterlab
that referenced
this pull request
Dec 19, 2022
Skip lib check for now while waiting for vega/vega-lite#8473 See the discussion in jupyterlab#13028 for more information
jtpio
added a commit
to jtpio/jupyterlab
that referenced
this pull request
Dec 20, 2022
Skip lib check for now while waiting for vega/vega-lite#8473 See the discussion in jupyterlab#13028 for more information
jtpio
added a commit
to jtpio/jupyterlab
that referenced
this pull request
Dec 22, 2022
Skip lib check for now while waiting for vega/vega-lite#8473 See the discussion in jupyterlab#13028 for more information
jtpio
added a commit
to jtpio/jupyterlab
that referenced
this pull request
Jan 4, 2023
Skip lib check for now while waiting for vega/vega-lite#8473 See the discussion in jupyterlab#13028 for more information
jasongrout
added a commit
to jasongrout/jupyterlab
that referenced
this pull request
Feb 5, 2023
jtpio
pushed a commit
to jasongrout/jupyterlab
that referenced
this pull request
Feb 17, 2023
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
* Constrain `isConditionalParameter` type parameter Fixes vega#8465 * Lint the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8465