Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix overloaded url for value.html #8690

Merged
merged 3 commits into from
Feb 12, 2023
Merged

docs: fix overloaded url for value.html #8690

merged 3 commits into from
Feb 12, 2023

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Feb 2, 2023

https://vega.github.io/vega-lite/docs/value.html was used for two pages (value on encodings and in params) and so one isn't accessible.

📦 Published PR as canary version: 5.6.1--canary.8690.f7cb3b9.0

✨ Test out this PR locally via:

npm install vega-lite@5.6.1--canary.8690.f7cb3b9.0
# or 
yarn add vega-lite@5.6.1--canary.8690.f7cb3b9.0

@domoritz domoritz requested a review from a team February 2, 2023 00:45
@domoritz
Copy link
Member Author

Merging since I think this is the correct fix. @kanitw @arvind feel free to follow up.

@domoritz domoritz enabled auto-merge (squash) February 12, 2023 19:30
@domoritz domoritz disabled auto-merge February 12, 2023 19:31
@domoritz domoritz merged commit 558f59b into next Feb 12, 2023
@domoritz domoritz deleted the dom/value branch February 12, 2023 19:31
@vega-org-bot
Copy link
Collaborator

🚀 PR was released in v5.7.0-next.0 🚀

BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
* docs: fix overloaded url for value.html

* chore: update TOC [CI]

---------

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants