Add Window class and options plugin decoration #3485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onWindow
is the BrowserWindow anddecorateBrowserOptions
decorate it.onWindow
doesn't refer to theWindow
object https://github.com/zeit/hyper/blob/canary/app/ui/window.js#L19The current implementation make the session creation happen before the instance of the window. There for, if the plugin want to bind a session to a window. The new
decorateSessionClass
anddecorateSessionOptions
will result on the session not being accessible to the window's instance of the plugin. And therefor, not being able to bind it to anUID
.This PR include more extensibility by allowing the developer to either access
onWindowClass
the window's uid, or decorate it usingdecorateWindowClass
.This enable the possibility to give window's profile ID as unique name
or acces the default
UID
created:Target: ppot/hyper-automator#4