Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Launch takes too long
Solution
Not a complete solution but an improvement.
Normally a window is created, and when it's ready it sends a
new
message. When the main process receives thenew
message, it creates a new session.Instead of waiting for the
new
message, the main process creates a session optimistically so that when thenew
messages is actually received, a session is already warmed up.Benchmarks
This measures the time from when
app/index.js
first runs until the firstsession data
message is sent to the renderer. Ran it 5 consecutive times.canary:
749, 728, 765, 777, 762
this branch:
617, 656, 615, 590, 596
Averages:
Not a hell of a lot but doesn't hurt either. I've only tested on Linux, but should help even more on other platforms