Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Actions CI, remove Circle CI #494

Merged
merged 8 commits into from
Feb 12, 2020
Merged

Add Github Actions CI, remove Circle CI #494

merged 8 commits into from
Feb 12, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Dec 13, 2019 •
edited
Loading

  • Remove Circle CI
  • Add GitHub Actions CI

This will make sure we are testing macOS since Circle CI has been failing for months.

@arunoda arunoda mentioned this pull request Jan 4, 2020
Merged
@styfle styfle changed the title Add github actions ci Add Github Actions CI Feb 12, 2020
@styfle styfle marked this pull request as ready for review February 12, 2020 15:44
@styfle styfle requested a review from Timer as a code owner February 12, 2020 15:44
@styfle styfle changed the title Add Github Actions CI Add Github Actions CI, remove Circle CI Feb 12, 2020
@styfle styfle requested a review from AndyBitz February 12, 2020 16:11
Timer
Timer approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@styfle styfle merged commit e2977af into master Feb 12, 2020
@styfle styfle deleted the gh-actions-ci branch February 12, 2020 16:16
@styfle styfle mentioned this pull request Mar 6, 2020
Merged
This was referenced Mar 12, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timer Timer Timer approved these changes

@AndyBitz AndyBitz Awaiting requested review from AndyBitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@styfle @Timer