Add transpileOnly support for TS projects if needed #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to build faster while we are developing. (As we are not much interest about the type accuracy) With some tests, we can gain upto 2X time reduction when building. I assume the benefit will be more than this for massive projects.
javivelasco
approved these changes
Jan 3, 2020
|
Amaze! |
styfle
reviewed
Jan 3, 2020
| @@ -177,6 +178,7 @@ module.exports = ( | |||
| { | |||
| loader: eval('__dirname + "/loaders/ts-loader.js"'), | |||
| options: { | |||
| transpileOnly, | |||
There was a problem hiding this comment.
Looks good, we just need a test for this new behavior
There was a problem hiding this comment.
@styfle sure thing. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to build faster while we are developing.
(As we are not much interest about the type accuracy)
With some tests, we can gain upto 2X time reduction when building.
I assume the benefit will be more than this for massive projects.