chore: add windows to CI

[styfle]

• Related to chore: add windows to CI webpack-asset-relocator-loader#155
• Related to Bug when compiling with Knex.js on windows 10 #593

[styfle]

@yichi-yang Any thoughts what could be wrong here? Looks like the tests already strip \r but its still showing up

ncc/test/unit.test.js

Lines 22 to 23 in 905222e

	// Windows support
	.replace(/\r/g, "");

[yichi-yang]

@yichi-yang Any thoughts what could be wrong here? Looks like the tests already strip \r but its still showing up

I'm not super familiar with the unit test setup here, but just by looking at the code my guess would be it's actualSourceMap that contain \rs?

ncc/test/unit.test.js

Line 81 in 905222e

expect(actualSourceMap).toBe(expectedSourceMap);

[styfle]

That one also has a replace, so still not sure why it fails CI 🤔

ncc/test/unit.test.js

Lines 76 to 79 in 905222e

	const actualSourceMap = map
	.trim()
	// Windows support
	.replace(/\r/g, "");

[yichi-yang]

Ah I think you need /\\r/g instead of /\r/g. Those \rs in map appear to already have been escaped.