Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add windows to CI #155

Merged
merged 3 commits into from
Mar 22, 2022
Merged

chore: add windows to CI #155

merged 3 commits into from
Mar 22, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 22, 2022

Add windows to CI matrix so we can run tests against windows

@styfle styfle changed the title [chore] Add windows to CI chore: add windows to CI Mar 22, 2022
@styfle
Copy link
Member Author

styfle commented Mar 22, 2022

Might be failing due to jestjs/jest#7914

@yichi-yang
Copy link
Contributor

I also ran into this problem earlier.

A temporary fix is to replace testMatch with "<rootDir>/test/*(*.)+(spec|test).js?(x)" here:

testMatch: ["<rootDir>/test/?(*.)+(spec|test).js?(x)"]

I also had to change this line:

const stdout = child_process.execSync(__dirname + "/../node_modules/.bin/webpack -c webpack.config.js", {

to

    const bin = path.join(__dirname, '..', 'node_modules', '.bin', 'webpack');
    const stdout = child_process.execSync(`"${bin}" -c webpack.config.js`, {

since my __dirname contains spaces.

@styfle styfle marked this pull request as ready for review March 22, 2022 23:46
@styfle styfle requested a review from Timer as a code owner March 22, 2022 23:46
@styfle styfle merged commit 5d4232d into main Mar 22, 2022
@styfle styfle deleted the add-windows-ci branch March 22, 2022 23:55
@github-actions
Copy link

🎉 This PR is included in version 1.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants