chore: add parallel rust frontend and remove unused rust dependencies (…

…vercel/turborepo#7409) ### Description Should improve compile times marginally, also added the new parallel frontend. Also includes some clippy fixes (`cargo-groups` seems to be broken). `turbopack-cli`: 761 -> 719 compilation units `turbo`: 574 -> 564 compilation units Closes PACK-2525
vercel · Apr 9, 2024 · 80847fb · 80847fb
1 parent 5ed785e
commit 80847fb
Show file tree

Hide file tree

Showing 30 changed files with 18 additions and 65 deletions.
diff --git a/crates/tower-uds/Cargo.toml b/crates/tower-uds/Cargo.toml
@@ -7,7 +7,6 @@ license = "MPL-2.0"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-http = "0.2.11"
 tokio = { workspace = true, features = ["net"] }
 tower = { version = "0.4.13", features = ["util"] }
 

diff --git a/crates/turbo-tasks-bytes/Cargo.toml b/crates/turbo-tasks-bytes/Cargo.toml
@@ -17,7 +17,6 @@ bytes = { workspace = true }
 futures = { workspace = true }
 serde = { workspace = true }
 serde_bytes = "0.11.9"
-tokio = { workspace = true }
 turbo-tasks = { workspace = true }
 
 [dev-dependencies]

diff --git a/crates/turbo-tasks-fetch/Cargo.toml b/crates/turbo-tasks-fetch/Cargo.toml
@@ -20,7 +20,6 @@ workspace = true
 
 [dependencies]
 anyhow = { workspace = true }
-indexmap = { workspace = true }
 lazy_static = { workspace = true }
 reqwest = { workspace = true }
 serde = { workspace = true }

diff --git a/crates/turbo-tasks-fs/src/lib.rs b/crates/turbo-tasks-fs/src/lib.rs
@@ -5,6 +5,7 @@
 #![feature(io_error_more)]
 #![feature(round_char_boundary)]
 #![feature(arbitrary_self_types)]
+#![feature(lint_reasons)]
 
 pub mod attach;
 pub mod embed;
@@ -249,6 +250,7 @@ impl DiskFileSystem {
     }
 }
 
+#[allow(dead_code, reason = "we need to hold onto the locks")]
 struct PathLockGuard<'a>(
     #[allow(dead_code)] RwLockReadGuard<'a, ()>,
     #[allow(dead_code)] mutex_map::MutexMapGuard<'a, PathBuf>,

diff --git a/crates/turbo-tasks-macros-tests/tests/value_debug.rs b/crates/turbo-tasks-macros-tests/tests/value_debug.rs
@@ -5,6 +5,7 @@ register!();
 
 #[tokio::test]
 async fn ignored_indexes() {
+    #[allow(dead_code)]
     #[derive(ValueDebugFormat)]
     struct IgnoredIndexes(
         #[allow(dead_code)]

diff --git a/crates/turbo-tasks-macros/Cargo.toml b/crates/turbo-tasks-macros/Cargo.toml
@@ -14,7 +14,6 @@ workspace = true
 
 [dependencies]
 anyhow = { workspace = true }
-convert_case = "0.6.0"
 proc-macro-error = "1.0.4"
 proc-macro2 = { workspace = true }
 quote = { workspace = true }

diff --git a/crates/turbo-tasks-memory/src/task/meta_state.rs b/crates/turbo-tasks-memory/src/task/meta_state.rs
@@ -88,6 +88,7 @@ pub(super) type TaskMetaStateAsPartialMut =
 pub(super) type TaskMetaStateAsUnloadedMut =
     for<'a> fn(&'a mut TaskMetaState) -> Option<&'a mut UnloadedTaskState>;
 
+#[allow(dead_code, reason = "test")]
 pub(super) enum TaskMetaStateReadGuard<'a> {
     Full(ReadGuard<'a, TaskMetaState, TaskState, TaskMetaStateAsFull>),
     Partial(ReadGuard<'a, TaskMetaState, PartialTaskState, TaskMetaStateAsPartial>),

diff --git a/crates/turbo-tasks-signposter/src/log.rs b/crates/turbo-tasks-signposter/src/log.rs
@@ -42,6 +42,7 @@ pub struct Log {
 
 // Safety: unclear
 unsafe impl Sync for Log {}
+
 // Safety: unclear
 unsafe impl Send for Log {}
 
@@ -82,6 +83,7 @@ pub struct Signpost {
 
 // Safety: unclear
 unsafe impl Sync for Signpost {}
+
 // Safety: unclear
 unsafe impl Send for Signpost {}
 

diff --git a/crates/turbo-tasks/Cargo.toml b/crates/turbo-tasks/Cargo.toml
@@ -37,7 +37,6 @@ regex = { workspace = true }
 serde = { workspace = true, features = ["rc", "derive"] }
 serde_json = { workspace = true }
 serde_regex = "1.1.0"
-stable_deref_trait = "1.2.0"
 thiserror = { workspace = true }
 tokio = { workspace = true, features = ["full"] }
 tracing = { workspace = true }

diff --git a/crates/turbo-tasks/src/task/concrete_task_input.rs b/crates/turbo-tasks/src/task/concrete_task_input.rs
@@ -41,9 +41,9 @@ impl PartialEq for SharedReference {
     // only compares their addresses.
     #[allow(ambiguous_wide_pointer_comparisons)]
     fn eq(&self, other: &Self) -> bool {
-        PartialEq::eq(
-            &(&*self.1 as *const (dyn Any + Send + Sync)),
-            &(&*other.1 as *const (dyn Any + Send + Sync)),
+        std::ptr::addr_eq(
+            &*self.1 as *const (dyn Any + Send + Sync),
+            &*other.1 as *const (dyn Any + Send + Sync),
         )
     }
 }

diff --git a/crates/turbopack-bench/Cargo.toml b/crates/turbopack-bench/Cargo.toml
@@ -21,19 +21,14 @@ anyhow = { workspace = true, features = ["backtrace"] }
 chromiumoxide = { workspace = true, features = [
   "tokio-runtime",
 ], default-features = false }
-clap = { workspace = true, features = ["derive", "env"], optional = true }
-console-subscriber = { workspace = true, optional = true }
 criterion = { workspace = true, features = ["async_tokio"] }
-dunce = { workspace = true }
 futures = { workspace = true }
-mime = { workspace = true }
 once_cell = { workspace = true }
 owo-colors = { workspace = true }
 parking_lot = { workspace = true }
 portpicker = "0.1.1"
 rand = { workspace = true }
 regex = { workspace = true }
-serde = { workspace = true }
 serde_json = { workspace = true }
 tempfile = { workspace = true }
 tokio = { workspace = true, features = ["full"] }
@@ -42,7 +37,6 @@ turbo-tasks = { workspace = true }
 turbo-tasks-testing = { workspace = true }
 turbopack-create-test-app = { workspace = true }
 url = { workspace = true }
-webbrowser = { workspace = true }
 
 [target.'cfg(unix)'.dependencies]
 nix = "0.26.1"
diff --git a/crates/turbopack-browser/Cargo.toml b/crates/turbopack-browser/Cargo.toml
@@ -31,14 +31,10 @@ urlencoding = { workspace = true }
 turbo-tasks = { workspace = true }
 turbo-tasks-fs = { workspace = true }
 turbo-tasks-hash = { workspace = true }
-turbopack = { workspace = true }
 turbopack-core = { workspace = true }
-turbopack-css = { workspace = true }
 turbopack-ecmascript = { workspace = true }
 turbopack-ecmascript-runtime = { workspace = true }
 turbopack-resolve = { workspace = true }
 
-swc_core = { workspace = true }
-
 [build-dependencies]
 turbo-tasks-build = { workspace = true }
diff --git a/crates/turbopack-cli-utils/Cargo.toml b/crates/turbopack-cli-utils/Cargo.toml
@@ -18,13 +18,11 @@ workspace = true
 anyhow = { workspace = true }
 clap = { workspace = true, features = ["derive"] }
 crossterm = "0.26.0"
-once_cell = { workspace = true }
 owo-colors = { workspace = true }
 serde = { workspace = true, features = ["derive"] }
 turbo-tasks = { workspace = true }
 turbo-tasks-fs = { workspace = true }
 turbopack-core = { workspace = true }
-turbopack-ecmascript = { workspace = true }
 turbopack-resolve = { workspace = true }
 
 [build-dependencies]

diff --git a/crates/turbopack-cli/Cargo.toml b/crates/turbopack-cli/Cargo.toml
@@ -42,16 +42,12 @@ workspace = true
 anyhow = { workspace = true, features = ["backtrace"] }
 clap = { workspace = true, features = ["derive", "env"] }
 console-subscriber = { workspace = true, optional = true }
-criterion = { workspace = true, features = ["async_tokio"] }
 dunce = { workspace = true }
 futures = { workspace = true }
 mime = { workspace = true }
-once_cell = { workspace = true }
 owo-colors = { workspace = true }
 serde = { workspace = true }
-serde_json = { workspace = true }
 tokio = { workspace = true, features = ["full"] }
-tracing = { workspace = true }
 tracing-subscriber = { workspace = true, features = ["env-filter", "json"] }
 turbo-tasks = { workspace = true }
 turbo-tasks-env = { workspace = true }
@@ -76,6 +72,7 @@ turbopack-trace-utils = { workspace = true }
 webbrowser = { workspace = true }
 
 [dev-dependencies]
+criterion = { workspace = true, features = ["async_tokio"] }
 regex = { workspace = true }
 turbopack-bench = { workspace = true }
 

diff --git a/crates/turbopack-core/Cargo.toml b/crates/turbopack-core/Cargo.toml
@@ -23,12 +23,10 @@ indexmap = { workspace = true }
 lazy_static = { workspace = true }
 once_cell = { workspace = true }
 patricia_tree = "0.5.5"
-qstring = { workspace = true }
 ref-cast = "1.0.20"
 regex = { workspace = true }
 serde = { workspace = true, features = ["rc"] }
 serde_json = { workspace = true, features = ["preserve_order"] }
-serde_qs = { workspace = true }
 sourcemap = { workspace = true }
 swc_core = { workspace = true, features = ["ecma_preset_env", "common"] }
 tracing = { workspace = true }

diff --git a/crates/turbopack-core/src/resolve/pattern.rs b/crates/turbopack-core/src/resolve/pattern.rs
@@ -458,7 +458,7 @@ impl Pattern {
                     static ref FORBIDDEN: Regex =
                         Regex::new(r"(/|^)(ROOT|\.|/|(node_modules|__tests?__)(/|$))").unwrap();
                     static ref FORBIDDEN_MATCH: Regex = Regex::new(r"\.d\.ts$|\.map$").unwrap();
-                };
+                }
                 if let Some(m) = FORBIDDEN.find(value) {
                     MatchResult::Consumed {
                         remaining: value,
@@ -569,7 +569,7 @@ impl Pattern {
                     static ref FORBIDDEN: Regex =
                         Regex::new(r"(/|^)(\.|(node_modules|__tests?__)(/|$))").unwrap();
                     static ref FORBIDDEN_MATCH: Regex = Regex::new(r"\.d\.ts$|\.map$").unwrap();
-                };
+                }
                 if let Some(m) = FORBIDDEN.find(value) {
                     NextConstantUntilResult::Consumed(value, Some(m.start()))
                 } else if FORBIDDEN_MATCH.find(value).is_some() {

diff --git a/crates/turbopack-css/Cargo.toml b/crates/turbopack-css/Cargo.toml
@@ -14,7 +14,6 @@ workspace = true
 
 [dependencies]
 anyhow = { workspace = true }
-async-trait = { workspace = true }
 indexmap = { workspace = true }
 indoc = { workspace = true }
 lightningcss = { workspace = true }

diff --git a/crates/turbopack-dev-server/Cargo.toml b/crates/turbopack-dev-server/Cargo.toml
@@ -25,7 +25,6 @@ hyper-tungstenite = "0.9.0"
 indexmap = { workspace = true, features = ["serde"] }
 mime = { workspace = true }
 mime_guess = "2.0.4"
-once_cell = { workspace = true }
 parking_lot = { workspace = true }
 pin-project-lite = { workspace = true }
 serde = { workspace = true }

diff --git a/crates/turbopack-ecmascript-plugins/Cargo.toml b/crates/turbopack-ecmascript-plugins/Cargo.toml
@@ -26,7 +26,6 @@ anyhow = { workspace = true }
 async-trait = { workspace = true }
 indexmap = { workspace = true }
 lightningcss = { workspace = true }
-parcel_selectors = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
 

diff --git a/crates/turbopack-ecmascript-runtime/Cargo.toml b/crates/turbopack-ecmascript-runtime/Cargo.toml
@@ -29,7 +29,5 @@ turbopack = { workspace = true }
 turbopack-core = { workspace = true }
 turbopack-ecmascript = { workspace = true }
 
-swc_core = { workspace = true }
-
 [build-dependencies]
 turbo-tasks-build = { workspace = true }
diff --git a/crates/turbopack-ecmascript/Cargo.toml b/crates/turbopack-ecmascript/Cargo.toml
@@ -16,7 +16,6 @@ workspace = true
 anyhow = { workspace = true }
 async-trait = { workspace = true }
 either = { workspace = true }
-futures = { workspace = true }
 indexmap = { workspace = true }
 indoc = { workspace = true }
 lazy_static = { workspace = true }
@@ -25,12 +24,10 @@ num-traits = "0.2.15"
 once_cell = { workspace = true }
 parking_lot = { workspace = true }
 petgraph = { workspace = true }
-pin-project-lite = { workspace = true }
 regex = { workspace = true }
 rustc-hash = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
-serde_qs = { workspace = true }
 sourcemap = { workspace = true }
 tokio = { workspace = true }
 tracing = { workspace = true }

diff --git a/crates/turbopack-ecmascript/src/tree_shake/graph.rs b/crates/turbopack-ecmascript/src/tree_shake/graph.rs
@@ -545,10 +545,8 @@ impl DepGraph {
                         _ => {}
                     },
                     ModuleDecl::ExportNamed(NamedExport {
-                        src: None,
-                        specifiers,
-                        ..
-                    }) => {
+                        src, specifiers, ..
+                    }) if src.is_none() => {
                         // We are not interested in re-exports.
                         for s in specifiers {
                             match s {

diff --git a/crates/turbopack-image/Cargo.toml b/crates/turbopack-image/Cargo.toml
@@ -29,7 +29,6 @@ image = { workspace = true, default-features = false, features = [
   "bmp",
   "tga",
 ] }
-indexmap = { workspace = true }
 mime = { workspace = true }
 once_cell = { workspace = true }
 regex = { workspace = true }

diff --git a/crates/turbopack-image/src/process/mod.rs b/crates/turbopack-image/src/process/mod.rs
@@ -52,14 +52,14 @@ impl BlurPlaceholder {
 #[serde_as]
 #[turbo_tasks::value]
 #[derive(Default)]
+#[non_exhaustive]
 pub struct ImageMetaData {
     pub width: u32,
     pub height: u32,
     #[turbo_tasks(trace_ignore, debug_ignore)]
     #[serde_as(as = "Option<DisplayFromStr>")]
     pub mime_type: Option<Mime>,
     pub blur_placeholder: Option<BlurPlaceholder>,
-    placeholder_for_future_extensions: (),
 }
 
 impl ImageMetaData {
@@ -69,7 +69,6 @@ impl ImageMetaData {
             height: 100,
             mime_type,
             blur_placeholder: Some(BlurPlaceholder::fallback()),
-            placeholder_for_future_extensions: (),
         }
     }
 }
@@ -369,7 +368,6 @@ pub async fn get_meta_data(
             height,
             mime_type: Some(mime::IMAGE_SVG),
             blur_placeholder: None,
-            placeholder_for_future_extensions: (),
         }
         .cell());
     }
@@ -407,7 +405,6 @@ pub async fn get_meta_data(
                     None
                 },
                 blur_placeholder,
-                placeholder_for_future_extensions: (),
             }
             .cell())
         }

diff --git a/crates/turbopack-node/Cargo.toml b/crates/turbopack-node/Cargo.toml
@@ -20,7 +20,6 @@ workspace = true
 anyhow = { workspace = true }
 async-stream = "0.3.4"
 async-trait = { workspace = true }
-bytes = { workspace = true }
 const_format = "0.2.30"
 futures = { workspace = true }
 futures-retry = { workspace = true }
@@ -33,7 +32,7 @@ parking_lot = { workspace = true }
 regex = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
-serde_qs = { workspace = true }
+#serde_qs = { workspace = true }
 tokio = { workspace = true, features = ["full"] }
 tracing = { workspace = true }
 turbo-tasks = { workspace = true }
@@ -45,8 +44,8 @@ turbopack-core = { workspace = true }
 turbopack-dev-server = { workspace = true }
 turbopack-ecmascript = { workspace = true }
 turbopack-resolve = { workspace = true }
-url = { workspace = true }
-urlencoding = { workspace = true }
+#url = { workspace = true }
+#urlencoding = { workspace = true }
 
 [build-dependencies]
 turbo-tasks-build = { workspace = true }
diff --git a/crates/turbopack-nodejs/Cargo.toml b/crates/turbopack-nodejs/Cargo.toml
@@ -23,17 +23,13 @@ anyhow = { workspace = true }
 indexmap = { workspace = true }
 indoc = { workspace = true }
 serde = { workspace = true }
-serde_json = { workspace = true }
-serde_qs = { workspace = true }
-sourcemap = { workspace = true }
 tracing = { workspace = true }
 urlencoding = { workspace = true }
 
 turbo-tasks = { workspace = true }
 turbo-tasks-fs = { workspace = true }
 turbo-tasks-hash = { workspace = true }
 turbopack-core = { workspace = true }
-turbopack-css = { workspace = true }
 turbopack-ecmascript = { workspace = true }
 turbopack-ecmascript-runtime = { workspace = true }
 

diff --git a/crates/turbopack-resolve/Cargo.toml b/crates/turbopack-resolve/Cargo.toml
@@ -14,17 +14,13 @@ workspace = true
 
 [dependencies]
 anyhow = { workspace = true }
-async-recursion = { workspace = true }
-futures = { workspace = true }
 indexmap = { workspace = true, features = ["serde"] }
 lazy_static = { workspace = true }
 regex = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
-tokio = { workspace = true }
 tracing = { workspace = true }
 turbo-tasks = { workspace = true }
-turbo-tasks-env = { workspace = true }
 turbo-tasks-fs = { workspace = true }
 turbopack-core = { workspace = true }