Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add parallel rust frontend and remove unused rust dependencies #7409

Merged
merged 11 commits into from
Apr 9, 2024
Merged

chore: add parallel rust frontend and remove unused rust dependencies #7409

merged 11 commits into from
Apr 9, 2024

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Feb 17, 2024 •
edited
Loading

Description

Should improve compile times marginally, also added the new parallel frontend.

Also includes some clippy fixes (cargo-groups seems to be broken).

turbopack-cli: 761 -> 719 compilation units
turbo: 574 -> 564 compilation units

Closes PACK-2525

@vercel Vercel
Copy link

vercel bot commented Feb 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 3:06pm
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 3:06pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 3:06pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 3:06pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 3:06pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 3:06pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 3:06pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 3:06pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 3:06pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 3:06pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 3:06pm

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/unused-dependencies branch 2 times, most recently from 5f4d006 to 760cfed Compare February 19, 2024 14:02
@ForsakenHarmony ForsakenHarmony mentioned this pull request Feb 19, 2024
Merged
sokra
sokra approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title should mention the parallel frontend change too

@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review April 8, 2024 15:21
@ForsakenHarmony ForsakenHarmony requested review from a team as code owners April 8, 2024 15:21
@ForsakenHarmony ForsakenHarmony changed the title chore: remove unused rust dependencies chore: add parallel rust frontend and remove unused rust dependencies Apr 8, 2024
@ForsakenHarmony ForsakenHarmony merged commit ac53aff into main Apr 9, 2024
58 of 61 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/unused-dependencies branch April 9, 2024 21:24
@kdy1 kdy1 mentioned this pull request Apr 10, 2024
Merged
kdy1 added a commit to vercel/next.js that referenced this pull request Apr 11, 2024
@kdy1
build: Update swc_core to v0.90.30 (#63790)
02dd1e5 
# Turbopack


* vercel/turborepo#7409 <!-- hrmny - chore: add
parallel rust frontend and remove unused rust dependencies -->
* vercel/turborepo#7920 <!-- Tobias Koppers - remove
warning when there is no PostCSS config -->
* vercel/turborepo#7929 <!-- Tim Neutkens - Remove
environment variables page from Turbopack docs -->
* vercel/turborepo#7926 <!-- Tim Neutkens - Remove
outdated section -->
* vercel/turborepo#7925 <!-- Tim Neutkens - Update
Turbopack CSS docs -->
* vercel/turborepo#7928 <!-- Tim Neutkens - Update
Next.js mention in Turbopack docs -->
* vercel/turborepo#7856 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.29` -->



### What?

Update SWC crates.

### Why?

1. To keep in sync
2. Prepare usage of source map range mappings.
getsentry/rust-sourcemap#77

### How?



Closes PACK-2860
@sokra sokra mentioned this pull request Apr 11, 2024
Merged
sokra added a commit to vercel/next.js that referenced this pull request Apr 11, 2024
@sokra
update turbopack (#64347)
cbee709 
* vercel/turborepo#7409 <!-- hrmny - chore: add
parallel rust frontend and remove unused rust dependencies -->
* vercel/turborepo#7920 <!-- Tobias Koppers - remove
warning when there is no PostCSS config -->
* vercel/turborepo#7856 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.29` -->
* vercel/turborepo#7941 <!-- Tobias Koppers - fix
recursion cycle when having a cycle of dynamic imports -->
* vercel/turborepo#7943 <!-- Tobias Koppers - fix
HMR by removing chunks from chunk list hash -->
@chris-olszewski chris-olszewski mentioned this pull request Apr 15, 2024
Merged
chris-olszewski added a commit that referenced this pull request Apr 16, 2024
@chris-olszewski
chore(ci): switch from action-rs/toolchain to actions-rust-lang/setup…
e07f0ba 
…-rust-toolchain (#7972)

### Description

#7409 deleted `rust-toolchain` in favor of `rust-toolchain.toml` which
isn't supported by the no longer maintained `action-rs/toolchain`

This broke our release process:
https://github.com/vercel/turbo/actions/runs/8695260821/job/23846306200#step:7:12

### Testing Instructions

[Release dry
run](https://github.com/vercel/turbo/actions/runs/8697187026)

Closes TURBO-2810
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Apr 16, 2024
@ForsakenHarmony
chore: remove unused rust dependencies (#62176)
ce69d02 
### What?

Toolchain is updated as well.

Should improve compile times marginally, also added the new parallel
frontend.

Depends on vercel/turborepo#7409

Closes PACK-2526
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@ForsakenHarmony
chore: add parallel rust frontend and remove unused rust dependencies (…
a40a235 
…vercel/turborepo#7409)

### Description

Should improve compile times marginally, also added the new parallel
frontend.

Also includes some clippy fixes (`cargo-groups` seems to be broken).

`turbopack-cli`: 761 -> 719 compilation units
`turbo`: 574 -> 564 compilation units

Closes PACK-2525
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
chore: add parallel rust frontend and remove unused rust dependencies (…
04e610d 
…vercel/turborepo#7409)

### Description

Should improve compile times marginally, also added the new parallel
frontend.

Also includes some clippy fixes (`cargo-groups` seems to be broken).

`turbopack-cli`: 761 -> 719 compilation units
`turbo`: 574 -> 564 compilation units

Closes PACK-2525
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
chore: add parallel rust frontend and remove unused rust dependencies (…
80847fb 
…vercel/turborepo#7409)

### Description

Should improve compile times marginally, also added the new parallel
frontend.

Also includes some clippy fixes (`cargo-groups` seems to be broken).

`turbopack-cli`: 761 -> 719 compilation units
`turbo`: 574 -> 564 compilation units

Closes PACK-2525
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@ForsakenHarmony
chore: add parallel rust frontend and remove unused rust dependencies (…
cb457fc 
…vercel/turborepo#7409)

### Description

Should improve compile times marginally, also added the new parallel
frontend.

Also includes some clippy fixes (`cargo-groups` seems to be broken).

`turbopack-cli`: 761 -> 719 compilation units
`turbo`: 574 -> 564 compilation units

Closes PACK-2525
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 14, 2024
@ForsakenHarmony
chore: remove unused rust dependencies (#62176)
5cb4959 
### What?

Toolchain is updated as well.

Should improve compile times marginally, also added the new parallel
frontend.

Depends on vercel/turborepo#7409

Closes PACK-2526
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 15, 2024
@ForsakenHarmony
chore: remove unused rust dependencies (#62176)
cea6903 
### What?

Toolchain is updated as well.

Should improve compile times marginally, also added the new parallel
frontend.

Depends on vercel/turborepo#7409

Closes PACK-2526
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 16, 2024
@ForsakenHarmony
chore: remove unused rust dependencies (#62176)
52b4e1b 
### What?

Toolchain is updated as well.

Should improve compile times marginally, also added the new parallel
frontend.

Depends on vercel/turborepo#7409

Closes PACK-2526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlyon arlyon arlyon approved these changes

@sokra sokra sokra approved these changes

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@gsoltis gsoltis Awaiting requested review from gsoltis gsoltis is a code owner automatically assigned from vercel/turbo-oss

@Zertsov Zertsov Awaiting requested review from Zertsov Zertsov is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci pkg: turbo-repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ForsakenHarmony @wbinnssmith @sokra @arlyon