chore: remove unused rust dependencies #62176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
Turbopack
ForsakenHarmony
force-pushed
the
hrmny/unused-dependencies
branch
from
c268758
to
265019f
Compare
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js hrmny/unused-dependencies | Change | |
|---|---|---|---|
| buildDuration | 14s | 14.1s | |
| buildDurationCached | 7.6s | 6.3s | N/A |
| nodeModulesSize | 199 MB | 199 MB | ✓ |
| nextStartRea..uration (ms) | 401ms | 405ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js hrmny/unused-dependencies | Change | |
|---|---|---|---|
| 2453-HASH.js gzip | 31.4 kB | 31.4 kB | N/A |
| 3304.HASH.js gzip | 181 B | 181 B | ✓ |
| 3f784ff6-HASH.js gzip | 53.7 kB | 53.7 kB | ✓ |
| 8299-HASH.js gzip | 5.1 kB | 5.1 kB | N/A |
| framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
| main-app-HASH.js gzip | 242 B | 241 B | N/A |
| main-HASH.js gzip | 29.6 kB | 29.6 kB | N/A |
| webpack-HASH.js gzip | 1.68 kB | 1.68 kB | N/A |
| Overall change | 99 kB | 99 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js hrmny/unused-dependencies | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js hrmny/unused-dependencies | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 196 B | 197 B | N/A |
| _error-HASH.js gzip | 184 B | 184 B | ✓ |
| amp-HASH.js gzip | 505 B | 505 B | ✓ |
| css-HASH.js gzip | 324 B | 325 B | N/A |
| dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | N/A |
| edge-ssr-HASH.js gzip | 258 B | 258 B | ✓ |
| head-HASH.js gzip | 352 B | 352 B | ✓ |
| hooks-HASH.js gzip | 370 B | 371 B | N/A |
| image-HASH.js gzip | 4.27 kB | 4.27 kB | ✓ |
| index-HASH.js gzip | 259 B | 259 B | ✓ |
| link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
| routerDirect..HASH.js gzip | 314 B | 312 B | N/A |
| script-HASH.js gzip | 386 B | 386 B | ✓ |
| withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 6.63 kB | 6.63 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js hrmny/unused-dependencies | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 483 B | 485 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js hrmny/unused-dependencies | Change | |
|---|---|---|---|
| index.html gzip | 528 B | 529 B | N/A |
| link.html gzip | 541 B | 542 B | N/A |
| withRouter.html gzip | 524 B | 523 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js hrmny/unused-dependencies | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 95.6 kB | 95.6 kB | N/A |
| page.js gzip | 3.05 kB | 3.05 kB | ✓ |
| Overall change | 3.05 kB | 3.05 kB | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js hrmny/unused-dependencies | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 623 B | 627 B | N/A |
| middleware-r..fest.js gzip | 155 B | 156 B | N/A |
| middleware.js gzip | 25.5 kB | 25.5 kB | N/A |
| edge-runtime..pack.js gzip | 839 B | 839 B | ✓ |
| Overall change | 839 B | 839 B | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js hrmny/unused-dependencies | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 171 kB | 171 kB | ✓ |
| app-page-exp..prod.js gzip | 97.5 kB | 97.5 kB | ✓ |
| app-page-tur..prod.js gzip | 99.2 kB | 99.2 kB | ✓ |
| app-page-tur..prod.js gzip | 93.5 kB | 93.5 kB | ✓ |
| app-page.run...dev.js gzip | 145 kB | 145 kB | ✓ |
| app-page.run..prod.js gzip | 92 kB | 92 kB | ✓ |
| app-route-ex...dev.js gzip | 21.5 kB | 21.5 kB | ✓ |
| app-route-ex..prod.js gzip | 15.2 kB | 15.2 kB | ✓ |
| app-route-tu..prod.js gzip | 15.2 kB | 15.2 kB | ✓ |
| app-route-tu..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
| app-route.ru...dev.js gzip | 21.1 kB | 21.1 kB | ✓ |
| app-route.ru..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
| pages-api-tu..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
| pages-api.ru...dev.js gzip | 9.82 kB | 9.82 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
| pages-turbo...prod.js gzip | 22.5 kB | 22.5 kB | ✓ |
| pages.runtim...dev.js gzip | 23.1 kB | 23.1 kB | ✓ |
| pages.runtim..prod.js gzip | 22.5 kB | 22.5 kB | ✓ |
| server.runti..prod.js gzip | 51.4 kB | 51.4 kB | ✓ |
| Overall change | 948 kB | 948 kB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js hrmny/unused-dependencies | Change | |
|---|---|---|---|
| 0.pack gzip | 1.58 MB | 1.58 MB | N/A |
| index.pack gzip | 107 kB | 107 kB | |
| Overall change | 107 kB | 107 kB |
Diff details
Diff for middleware.js
Diff too large to display
ForsakenHarmony
force-pushed
the
hrmny/unused-dependencies
branch
4 times, most recently
from
21b5e69
to
93b7153
Compare
ForsakenHarmony
force-pushed
the
hrmny/unused-dependencies
branch
6 times, most recently
from
5a1694f
to
05c4c06
Compare
ForsakenHarmony
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
ForsakenHarmony
requested review from
ismaelrumzan and
StephDietz
and removed request for
a team
ForsakenHarmony
force-pushed
the
hrmny/unused-dependencies
branch
2 times, most recently
from
f8b6085
to
dcbcbc4
Compare
bgw
approved these changes
Apr 15, 2024
| "--cfg", | ||
| "tokio_unstable", | ||
| "-Zshare-generics=y", # make the current crate share its generic instantiations | ||
| "-Zthreads=8", # parallel frontend https://blog.rust-lang.org/2023/11/09/parallel-rustc.html |
There was a problem hiding this comment.
Nice!
Given that this is still pretty experimental and has known bugs, I think it'd be better to do this in a separate commit/PR so that if we run into issues and have to bisect, it's easier to isolate.
The blog post says:
In multi-threaded mode there are some known bugs, including deadlocks. If compilation hangs, you have probably hit one of them.
| @@ -0,0 +1,4 @@ | |||
| [toolchain] | |||
| channel = "nightly-2024-04-03" | |||
| components = ["rustfmt", "clippy"] | |||
There was a problem hiding this comment.
If we're touching this anyways, should we also add rust-analyzer? It shouldn't cause any problems, just increased disk usage for people who might not want it. It's a bit annoying for me on every toolchain update to have to manually enable this component.
There was a problem hiding this comment.
Are you on vim/emacs? I use zed/vscode which I believe both just bundle it themselves so I've not had this issue. Not against it, just interested in your setup
ForsakenHarmony
force-pushed
the
hrmny/unused-dependencies
branch
from
69d42ca
to
bf84647
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Toolchain is updated as well.
Should improve compile times marginally, also added the new parallel frontend.
Depends on vercel/turborepo#7409
Closes PACK-2526