Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-loadable-manifest can be missing needed modules in some cases #22741

Closed
ijjk opened this issue Mar 3, 2021 · 3 comments · Fixed by #24281
Closed

react-loadable-manifest can be missing needed modules in some cases #22741

ijjk opened this issue Mar 3, 2021 · 3 comments · Fixed by #24281
Assignees
@sokra @ijjk
Milestone
Iteration 19

Comments

@ijjk
Copy link
Member

ijjk commented Mar 3, 2021

When using next/dynamic, the react-loadable-manifest plugin can fail to include modules that should be included.

We need to update the react-loadable-manifest plugin to handle these cases as well as attempt to add a test for this as well.

This was initially noticed while using next/dynamic on the Vercel blog and is currently the only reproduction. This occurs with both webpack 4 and webpack 5.

When these modules aren't included in the react-loadable-manifest it can cause hydration issues since we aren't waiting for all of the needed modules to be loaded before hydrating.
@ijjk ijjk added this to the iteration 17 milestone Mar 3, 2021
@ijjk ijjk mentioned this issue Mar 3, 2021
Closed
2 tasks
@Saci46

This comment has been minimized.

Sign in to view
@timneutkens
Copy link
Member

Please don't spam issues.

@timneutkens timneutkens modified the milestones: Iteration 18, Iteration 19 Apr 8, 2021
@ijjk ijjk added point: 21 and removed point: 5 labels Apr 20, 2021
@ijjk ijjk assigned sokra and ijjk Apr 20, 2021
@ijjk ijjk mentioned this issue Apr 20, 2021
Merged
2 tasks
@kodiakhq kodiakhq bot closed this as completed in #24281 Apr 21, 2021
kodiakhq bot pushed a commit that referenced this issue Apr 21, 2021
@sokra
improve react-loadable-plugin (#24281)
08baf52 
Co-authored-by: JJ Kasper <jj@jjsweb.site>



## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added


Closes: #22741
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this issue Apr 21, 2021
@sokra @SokratisVidros
improve react-loadable-plugin (vercel#24281)
f1848f0 
Co-authored-by: JJ Kasper <jj@jjsweb.site>



## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added


Closes: vercel#22741
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sokra sokra

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
Iteration 19
Development

Successfully merging a pull request may close this issue.

improve react-loadable-plugin vercel/next.js
5 participants
@sokra @timneutkens @balazsorban44 @ijjk @Saci46