improve react-loadable-plugin #24281

sokra · 2021-04-20T18:41:50Z

Co-authored-by: JJ Kasper jj@jjsweb.site

Bug

Related issues linked using fixes #number
Integration tests added

Closes: #22741

Co-authored-by: JJ Kasper <jj@jjsweb.site>

ijjk · 2021-04-20T20:28:23Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
buildDuration	14.4s	14.3s	-16ms
buildDurationCached	4.7s	4.5s	-195ms
nodeModulesSize	46.6 MB	46.6 MB	⚠️ +5.98 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.452	2.444	-0.01
/ avg req/sec	1019.52	1023.07	+3.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.269	1.245	-0.02
/error-in-render avg req/sec	1970.35	2007.64	+37.29

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.12 kB	7.12 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	9.52 kB	9.52 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
index.html gzip	611 B	611 B	✓
link.html gzip	616 B	616 B	✓
withRouter.html gzip	605 B	605 B	✓
Overall change	1.83 kB	1.83 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
buildDuration	17.9s	17.7s	-241ms
buildDurationCached	6.8s	6.7s	-63ms
nodeModulesSize	46.6 MB	46.6 MB	⚠️ +5.98 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.12 kB	7.12 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	9.52 kB	9.52 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_error.js	1.39 MB	1.39 MB	-272 B
404.html	2.76 kB	2.76 kB	✓
500.html	2.75 kB	2.75 kB	✓
amp.amp.html	10.7 kB	10.7 kB	✓
amp.html	1.96 kB	1.96 kB	✓
css.html	2.13 kB	2.13 kB	✓
hooks.html	2.01 kB	2.01 kB	✓
index.js	1.39 MB	1.39 MB	-270 B
link.js	1.45 MB	1.45 MB	-272 B
routerDirect.js	1.44 MB	1.44 MB	-272 B
withRouter.js	1.44 MB	1.44 MB	-272 B
Overall change	7.15 MB	7.15 MB	-1.36 kB

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
buildDuration	11.7s	11.7s	-76ms
buildDurationCached	4.9s	4.8s	-99ms
nodeModulesSize	46.6 MB	46.6 MB	⚠️ +5.98 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.362	2.377	⚠️ +0.01
/ avg req/sec	1058.45	1051.65	⚠️ -6.8
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.238	1.288	⚠️ +0.05
/error-in-render avg req/sec	2019.91	1940.5	⚠️ -79.41

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.2 kB	7.2 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.71 kB	3.71 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
21c68fa65a48..217.css gzip	125 B	125 B	✓
Overall change	9.36 kB	9.36 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_buildManifest.js gzip	419 B	419 B	✓
Overall change	419 B	419 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 4381e97

ijjk · 2021-04-21T11:04:47Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
buildDuration	16.4s	16.8s	⚠️ +437ms
buildDurationCached	5.7s	5.3s	-368ms
nodeModulesSize	46.6 MB	46.6 MB	⚠️ +5.98 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.805	2.898	⚠️ +0.09
/ avg req/sec	891.28	862.7	⚠️ -28.58
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.695	1.613	-0.08
/error-in-render avg req/sec	1474.86	1549.62	+74.76

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.12 kB	7.12 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	9.52 kB	9.52 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
index.html gzip	610 B	610 B	✓
link.html gzip	615 B	615 B	✓
withRouter.html gzip	604 B	604 B	✓
Overall change	1.83 kB	1.83 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
buildDuration	20s	20s	⚠️ +13ms
buildDurationCached	7.4s	7.5s	⚠️ +57ms
nodeModulesSize	46.6 MB	46.6 MB	⚠️ +5.98 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.12 kB	7.12 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	9.52 kB	9.52 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_error.js	1.39 MB	1.39 MB	-272 B
404.html	2.76 kB	2.76 kB	✓
500.html	2.75 kB	2.75 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.96 kB	1.96 kB	✓
css.html	2.13 kB	2.13 kB	✓
hooks.html	2.01 kB	2.01 kB	✓
index.js	1.39 MB	1.39 MB	-270 B
link.js	1.45 MB	1.45 MB	-272 B
routerDirect.js	1.44 MB	1.44 MB	-274 B
withRouter.js	1.44 MB	1.44 MB	-272 B
Overall change	7.15 MB	7.15 MB	-1.36 kB

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
buildDuration	14.1s	14s	-160ms
buildDurationCached	5.8s	5.7s	-78ms
nodeModulesSize	46.6 MB	46.6 MB	⚠️ +5.98 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.827	2.837	⚠️ +0.01
/ avg req/sec	884.23	881.17	⚠️ -3.06
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.594	1.622	⚠️ +0.03
/error-in-render avg req/sec	1568.2	1541.64	⚠️ -26.56

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.2 kB	7.2 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.71 kB	3.71 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
21c68fa65a48..217.css gzip	125 B	125 B	✓
Overall change	9.36 kB	9.36 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
_buildManifest.js gzip	419 B	419 B	✓
Overall change	419 B	419 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/hyration	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	605 B	605 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 0744ae7

Co-authored-by: JJ Kasper <jj@jjsweb.site> ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added Closes: vercel#22741

This bumps the babel cache key since we modified the `react-loadable` babel plugin and we don't want any cached versions used since the module names generated in previous cached version won't match the newly expected values. x-ref: #24281 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes

shobhitsharma · 2021-05-03T08:05:27Z

@timneutkens This PR has an issue regarding jest setup for many projects upgrading to next v10.2, any patch available?

related: #24566

improve react-loadable-plugin

80b0515

Co-authored-by: JJ Kasper <jj@jjsweb.site>

sokra requested review from divmain, ijjk, lfades, shuding and timneutkens as code owners April 20, 2021 18:41

ijjk mentioned this pull request Apr 20, 2021

Ensure react loadable manifest includes all needed requests #21216

Closed

2 tasks

ijjk added 2 commits April 20, 2021 13:58

Update type and add another check

94e53cb

Merge remote-tracking branch 'upstream/canary' into bugfix/hyration

57f438b

ijjk added the type: next label Apr 20, 2021

This comment has been minimized.

Sign in to view

Update manifest tests

5eea19d

This comment has been minimized.

Sign in to view

ijjk added 2 commits April 20, 2021 15:15

Make moduleName relative to pages dir

bf15bea

Merge remote-tracking branch 'upstream/canary' into bugfix/hyration

4381e97

timneutkens approved these changes Apr 21, 2021

View reviewed changes

Merge branch 'canary' into bugfix/hyration

0744ae7

kodiakhq bot merged commit 08baf52 into canary Apr 21, 2021

kodiakhq bot deleted the bugfix/hyration branch April 21, 2021 11:18

ijjk mentioned this pull request Apr 22, 2021

Bump next-babel-loader cache key #24335

Merged

8 tasks

bcomnes mentioned this pull request Apr 28, 2021

Jest tests failing when testing components with dynamic import in Next 10.2.0 #24566

Closed

datagutt mentioned this pull request May 11, 2021

Extracting fails when next/dynamic is used lingui/js-lingui#1058

Closed

sync-by-unito bot mentioned this pull request May 18, 2021

chore(deps): bump next from 10.0.7 to 10.2.0 filecoin-project/slate#736

Closed

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve react-loadable-plugin #24281

improve react-loadable-plugin #24281

sokra commented Apr 20, 2021 •

edited by ijjk

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Apr 20, 2021

ijjk commented Apr 21, 2021

shobhitsharma commented May 3, 2021 •

edited

Loading

improve react-loadable-plugin #24281

improve react-loadable-plugin #24281

Conversation

sokra commented Apr 20, 2021 • edited by ijjk Loading

Bug

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Apr 20, 2021

Stats from current PR

ijjk commented Apr 21, 2021

Stats from current PR

shobhitsharma commented May 3, 2021 • edited Loading

sokra commented Apr 20, 2021 •

edited by ijjk

Loading

shobhitsharma commented May 3, 2021 •

edited

Loading