Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next lint adds unnecessary absolute path distDir to include in tsconfig.json #62796

Closed
devjiwonchoi opened this issue Mar 4, 2024 · 1 comment · Fixed by #62797
Closed

next lint adds unnecessary absolute path distDir to include in tsconfig.json #62796

devjiwonchoi opened this issue Mar 4, 2024 · 1 comment · Fixed by #62797
Labels
bug Issue was opened via the bug report template. locked

Comments

@devjiwonchoi
Copy link
Member

Link to the code that reproduces this issue

https://github.com/devjiwonchoi/repro-next-lint-adds-unnecessary-tsconfig-include

To Reproduce

  1. Run pnpm next lint
  2. It will modify the tsconfig.json to add an unnecessary include.

Current vs. Expected behavior

Adds absolute path to the distDir, which is a duplicate of ".next/types/**/*.ts".

{
  "compilerOptions": {
    "include": [
      "next-env.d.ts",
      "**/*.ts",
      "**/*.tsx",
      ".next/types/**/*.ts",
      "/Users/devjiwonchoi/DevLife/OpenSource/jiwonchoi.dev/.next/types/**/*.ts"
    ],
  }
}

Provide environment information

Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 23.1.0: Mon Oct  9 21:32:11 PDT 2023; root:xnu-10002.41.9~7/RELEASE_ARM64_T6030
  Available memory (MB): 18432
  Available CPU cores: 11
Binaries:
  Node: 18.17.1
  npm: 9.6.7
  Yarn: 1.22.19
  pnpm: 8.15.4
Relevant Packages:
  next: 14.1.2-canary.3 // Latest available version is detected (14.1.2-canary.3).
  eslint-config-next: 14.1.2-canary.3
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.3.3
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

ESLint (eslint-config-next)

Which stage(s) are affected? (Select all that apply)

next dev (local)

Additional context

This issue was introduced on the latest canary version. Suspecting #61877.

@devjiwonchoi devjiwonchoi added the bug Issue was opened via the bug report template. label Mar 4, 2024
samcx added a commit that referenced this issue Mar 4, 2024
This PR reverts part of #61877 passing an absolute path to the distDir
value when running `next lint`.

Fixes #62796

Co-authored-by: Sam Ko <sam@vercel.com>
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. locked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant