-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add res.redirect
response helper
#14705
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
cad0d12
Add `res.redirect` response helper
botv 88cdad2
Merge branch 'canary' into response-helpers
botv 514d6bf
Revert unnecessary changes
botv dff7b14
Match Express signature for `res.redirect`
botv 001dcff
Merge branch 'response-helpers' of https://github.com/botv/next.js in…
botv a741d04
Add documentation for `res.redirect`
botv c7b82a7
Update packages/next/next-server/lib/utils.ts
botv f256bb4
Update packages/next/next-server/server/api-utils.ts
botv c43e2cd
Update packages/next/next-server/server/api-utils.ts
botv 5ffe4f7
Update packages/next/next-server/server/api-utils.ts
botv 3849a25
Fix errors from renamed parameter
botv 2b4f62e
Add tests
botv a227119
Merge branch 'canary' into response-helpers
botv 58c54fc
Change status code to 307
botv 35d96f8
Merge branch 'response-helpers' of https://github.com/botv/next.js in…
botv 540c229
Update examples with new redirect helper
botv 76d702c
Update docs with new redirect helper
botv b0cc648
Merge branch 'canary' into response-helpers
botv 6fb56ba
Merge branch 'canary' into response-helpers
botv babea12
Undo examples updates
botv 7350832
Merge branch 'response-helpers' of https://github.com/botv/next.js in…
botv 73c7fb7
Merge branch 'canary' into response-helpers
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export default (req, res) => { | ||
res.redirect(301, '/login') | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export default (req, res) => { | ||
res.redirect('/login') | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be 307? @Timer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #14947 @SarKurd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, maybe here should say
res.redirect([status], path)
instead ofres.redirect([status,] path)
, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebadiaz-arg written to mirror https://expressjs.com/en/api.html#res.redirect