fix: dockerfile npm run build #61466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed comment suggesting to use npm as an alternative but it's already configured by default.
stefangeneralao
requested review from
manovotny and
lydiahallie
and removed request for
a team
styfle
approved these changes
Jan 31, 2024
|
@styfle Yes, exactly right. The file had the following two days ago: |
styfle
reviewed
Jan 31, 2024
styfle
approved these changes
Jan 31, 2024
|
Beautiful! Thanks |
styfle
pushed a commit
that referenced
this pull request
Feb 1, 2024
### Adding or Updating Examples - Example: [with-docker](https://github.com/vercel/next.js/tree/canary/examples/with-docker) - Update: The latest change introduced in #61466 on the building process of NextJS when the package manager is PNPM is currently throwing an error (it works for npm though). **To replicate the error:** 1. Checkout on the **with-docker** example 2. Install with PNPM so that it generates the pnpm-lock.yaml 3. Build the Docker image -> This will fail on the _builder stage_ step that runs `pnpm run build`. **Possible Solution:** - Run `corepack enable pnpm` before building with pnpm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed comment suggesting to use npm as an alternative but it's already configured by default.