Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dockerfile npm run build #61466

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix: dockerfile npm run build #61466

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
911a100
Remove legacy comment
stefangeneralao Jan 31, 2024
a5bdc65
Apply if/else suggestion
styfle Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions examples/with-docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ COPY . .

RUN npm run build
styfle marked this conversation as resolved.
Show resolved Hide resolved

# If using npm comment out above and use below instead
# RUN npm run build

# Production image, copy all the files and run next
FROM base AS runner
WORKDIR /app
Expand Down
Loading