refactor(test): expose test mode as re-exported variables

[balazsorban44]

What?

Getting rid of unsafe/verbose global as any usage in tests.

This PR focuses on the usage of isNextDev, isNextDeploy and isNextStart properties that were previously set on global.

Why?

Consistency/type safety. Less mental overhead while working with tests.

This PR also caught the following false-positive tests. Meaning they were passing before, but actually did not test anything. This is because they were run under the unsafe (global as any).isDev condition, which is a misspelling of isNextDev. See them for a detailed explanation:

• b2862dd (#63217)
• 78ede13 (#63217)

How?

Instead of unsafe/verbose global as any, we can use the re-exported properties from e2e-utils.

NOTE: To the reviewer. "Hide whitespace changes" will simplify the diff view for some tests.

Closes NEXT-2793
Closes NEXT-2796
Supersedes #63217

[balazsorban44]

• refactor(test): expose test mode as re-exported variables #63240 : 2 dependent PRs (#63241 , #63243 ) 👈
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @balazsorban44 and the rest of your teammates on Graphite

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_expose_test_mode_as_re-exported_variables	Change
buildDuration	14.3s	14.4s	N/A
buildDurationCached	7.9s	6.7s	N/A
nodeModulesSize	198 MB	198 MB	✓
nextStartRea..uration (ms)	437ms	438ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_expose_test_mode_as_re-exported_variables	Change
2453-HASH.js gzip	30.4 kB	30.4 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	N/A
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	242 B	243 B	N/A
main-HASH.js gzip	32.2 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	45.4 kB	45.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_expose_test_mode_as_re-exported_variables	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_expose_test_mode_as_re-exported_variables	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.21 kB	4.21 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.57 kB	6.57 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_expose_test_mode_as_re-exported_variables	Change
_buildManifest.js gzip	481 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_expose_test_mode_as_re-exported_variables	Change
index.html gzip	530 B	527 B	N/A
link.html gzip	541 B	540 B	N/A
withRouter.html gzip	525 B	522 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_expose_test_mode_as_re-exported_variables	Change
edge-ssr.js gzip	95.1 kB	95.1 kB	N/A
page.js gzip	3.07 kB	3.07 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_expose_test_mode_as_re-exported_variables	Change
middleware-b..fest.js gzip	627 B	623 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_expose_test_mode_as_re-exported_variables	Change
app-page-exp...dev.js gzip	171 kB	171 kB	✓
app-page-exp..prod.js gzip	96.6 kB	96.6 kB	✓
app-page-tur..prod.js gzip	98.3 kB	98.3 kB	✓
app-page-tur..prod.js gzip	92.8 kB	92.8 kB	✓
app-page.run...dev.js gzip	149 kB	149 kB	✓
app-page.run..prod.js gzip	91.3 kB	91.3 kB	✓
app-route-ex...dev.js gzip	21.3 kB	21.3 kB	✓
app-route-ex..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	14.8 kB	14.8 kB	✓
app-route.ru...dev.js gzip	21 kB	21 kB	✓
app-route.ru..prod.js gzip	14.8 kB	14.8 kB	✓
pages-api-tu..prod.js gzip	9.52 kB	9.52 kB	✓
pages-api.ru...dev.js gzip	9.8 kB	9.8 kB	✓
pages-api.ru..prod.js gzip	9.52 kB	9.52 kB	✓
pages-turbo...prod.js gzip	22.3 kB	22.3 kB	✓
pages.runtim...dev.js gzip	22.9 kB	22.9 kB	✓
pages.runtim..prod.js gzip	22.3 kB	22.3 kB	✓
server.runti..prod.js gzip	50.5 kB	50.5 kB	✓
Overall change	948 kB	948 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_expose_test_mode_as_re-exported_variables	Change
0.pack gzip	1.56 MB	1.55 MB	N/A
index.pack gzip	105 kB	106 kB	⚠️ +539 B
Overall change	105 kB	106 kB	⚠️ +539 B

Diff details

Diff for middleware.js

Diff too large to display

Commit: 224bf13