refactor(test): use imported test mode instead of `global` in tests #63243

balazsorban44 · 2024-03-13T12:53:30Z

Closes NEXT-2799

balazsorban44 · 2024-03-13T12:53:45Z

refactor(test): drop global as any test modes #63244
refactor(test): use imported test mode instead of global in tests #63243 👈
refactor(test): expose test mode as re-exported variables #63240 : 1 other dependent PR (#63241 )
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @balazsorban44 and the rest of your teammates on Graphite

ijjk · 2024-03-13T13:08:09Z

Failing test suites

Commit: de7048c

TURBOPACK=1 pnpm test-start test/e2e/next-font/index.test.ts (turbopack)

next/font > app > import values > page with font
next/font > app > import values > page with local fonts
next/font > app > import values > Variable font without weight range

Expand output

● next/font › app › import values › page with font

expect(received).toEqual(expected) // deep equality

- Expected  - 2
+ Received  + 2

  Object {
-   "className": StringMatching /^className__.*__.{6}$/,
+   "className": "open_sans_51ef63f8-module__po25MG__className",
    "style": Object {
      "fontFamily": StringMatching /^'__Open_Sans_.{6}', '__Open_Sans_Fallback_.{6}'$/,
      "fontStyle": "normal",
    },
-   "variable": StringMatching /^variable__.*__.{6}$/,
+   "variable": "open_sans_51ef63f8-module__po25MG__variable",
  }

  88 |
  89 |           // _app.js
> 90 |           expect(JSON.parse($('#app-open-sans').text())).toEqual({
     |                                                          ^
  91 |             className: expect.stringMatching(getClassNameRegex('className')),
  92 |             variable: expect.stringMatching(getClassNameRegex('variable')),
  93 |             style: {

  at Object.toEqual (e2e/next-font/index.test.ts:90:58)

● next/font › app › import values › page with local fonts

expect(received).toEqual(expected) // deep equality

- Expected  - 2
+ Received  + 2

  Object {
-   "className": StringMatching /^className__.*__.{6}$/,
+   "className": "open_sans_51ef63f8-module__po25MG__className",
    "style": Object {
      "fontFamily": StringMatching /^'__Open_Sans_.{6}', '__Open_Sans_Fallback_.{6}'$/,
      "fontStyle": "normal",
    },
-   "variable": StringMatching /^variable__.*__.{6}$/,
+   "variable": "open_sans_51ef63f8-module__po25MG__variable",
  }

  139 |
  140 |           // _app.js
> 141 |           expect(JSON.parse($('#app-open-sans').text())).toEqual({
      |                                                          ^
  142 |             className: expect.stringMatching(getClassNameRegex('className')),
  143 |             variable: expect.stringMatching(getClassNameRegex('variable')),
  144 |             style: {

  at Object.toEqual (e2e/next-font/index.test.ts:141:58)

● next/font › app › import values › Variable font without weight range

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Object {
-   "className": StringMatching /^className__.*__.{6}$/,
+   "className": "nabla_abb2401d-module__ks7jmG__className",
    "style": Object {
      "fontFamily": StringMatching /^'__Nabla_.{6}', '__Nabla_Fallback_.{6}'$/,
      "fontStyle": "normal",
    },
  }

  179 |           const $ = cheerio.load(html)
  180 |
> 181 |           expect(JSON.parse($('#nabla').text())).toEqual({
      |                                                  ^
  182 |             className: expect.stringMatching(getClassNameRegex('className')),
  183 |             style: {
  184 |               fontFamily: expect.stringMatching(

  at Object.toEqual (e2e/next-font/index.test.ts:181:50)

Read more about building and testing Next.js in contributing.md.

ijjk · 2024-03-13T13:11:17Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests	Change
buildDuration	14s	14s	N/A
buildDurationCached	7.5s	6.2s	N/A
nodeModulesSize	199 MB	199 MB	✓
nextStartRea..uration (ms)	401ms	409ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests	Change
2453-HASH.js gzip	31.4 kB	31.4 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	✓
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	241 B	242 B	N/A
main-HASH.js gzip	32.2 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	99 kB	99 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.21 kB	4.21 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.57 kB	6.57 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests	Change
_buildManifest.js gzip	481 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests	Change
index.html gzip	528 B	528 B	✓
link.html gzip	541 B	541 B	✓
withRouter.html gzip	524 B	523 B	N/A
Overall change	1.07 kB	1.07 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests	Change
edge-ssr.js gzip	95.4 kB	95.4 kB	N/A
page.js gzip	3.06 kB	3.06 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests	Change
middleware-b..fest.js gzip	625 B	624 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests	Change
app-page-exp...dev.js gzip	170 kB	170 kB	✓
app-page-exp..prod.js gzip	97 kB	97 kB	✓
app-page-tur..prod.js gzip	98.8 kB	98.8 kB	✓
app-page-tur..prod.js gzip	93 kB	93 kB	✓
app-page.run...dev.js gzip	144 kB	144 kB	✓
app-page.run..prod.js gzip	91.5 kB	91.5 kB	✓
app-route-ex...dev.js gzip	21.4 kB	21.4 kB	✓
app-route-ex..prod.js gzip	15.2 kB	15.2 kB	✓
app-route-tu..prod.js gzip	15.2 kB	15.2 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route.ru...dev.js gzip	21.1 kB	21.1 kB	✓
app-route.ru..prod.js gzip	14.9 kB	14.9 kB	✓
pages-api-tu..prod.js gzip	9.55 kB	9.55 kB	✓
pages-api.ru...dev.js gzip	9.82 kB	9.82 kB	✓
pages-api.ru..prod.js gzip	9.55 kB	9.55 kB	✓
pages-turbo...prod.js gzip	22.5 kB	22.5 kB	✓
pages.runtim...dev.js gzip	23.1 kB	23.1 kB	✓
pages.runtim..prod.js gzip	22.4 kB	22.4 kB	✓
server.runti..prod.js gzip	51 kB	51 kB	✓
Overall change	945 kB	945 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests	Change
0.pack gzip	1.58 MB	1.58 MB	⚠️ +920 B
index.pack gzip	107 kB	106 kB	N/A
Overall change	1.58 MB	1.58 MB	⚠️ +920 B

Diff details

Diff for middleware.js

Diff too large to display

Commit: de7048c

…_instead_of_global_in_tests

ijjk added Font (next/font) Related to Next.js Font Optimization. area: tests created-by: Next.js team PRs by the Next.js team. labels Mar 13, 2024

balazsorban44 marked this pull request as ready for review March 13, 2024 12:53

balazsorban44 requested review from timneutkens, ijjk, shuding, huozhi, feedthejim, ztanner and wyattjoh as code owners March 13, 2024 12:53

This was referenced Mar 13, 2024

refactor(test): expose test mode as re-exported variables #63240

Merged

refactor(test): don't use global as any in test utils #63241

Merged

chore(test): fix false-positive tests #63242

Merged

balazsorban44 mentioned this pull request Mar 13, 2024

refactor(test): drop global as any test modes #63244

Closed

balazsorban44 force-pushed the 03-13-chore_test_fix_false-positive_tests branch from effb9a1 to 48ca884 Compare March 13, 2024 18:08

balazsorban44 force-pushed the 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests branch from 7cf1899 to 4c64c32 Compare March 13, 2024 18:09

balazsorban44 added 4 commits March 13, 2024 19:21

refactor(test): expose test mode as re-exported variables

c783e4c

refactor(test): use imported test mode instead of global in tests

de55bb1

revert next font changes

662589f

revert more

76ed523

balazsorban44 changed the base branch from 03-13-chore_test_fix_false-positive_tests to 03-13-refactor_test_expose_test_mode_as_re-exported_variables March 13, 2024 18:27

balazsorban44 force-pushed the 03-13-refactor_test_use_imported_test_mode_instead_of_global_in_tests branch from 7947df5 to 76ed523 Compare March 13, 2024 18:27

balazsorban44 requested review from a team as code owners March 13, 2024 18:27

balazsorban44 removed the request for review from a team March 13, 2024 18:27

balazsorban44 requested review from manovotny and leerob March 13, 2024 18:27

balazsorban44 force-pushed the 03-13-refactor_test_expose_test_mode_as_re-exported_variables branch from c783e4c to 224bf13 Compare March 13, 2024 18:32

Base automatically changed from 03-13-refactor_test_expose_test_mode_as_re-exported_variables to canary March 20, 2024 01:03

Merge branch 'canary' into 03-13-refactor_test_use_imported_test_mode…

557d5aa

…_instead_of_global_in_tests

balazsorban44 enabled auto-merge (squash) March 26, 2024 10:36

Merge branch 'canary' into 03-13-refactor_test_use_imported_test_mode…

de7048c

…_instead_of_global_in_tests

balazsorban44 added tests and removed area: tests labels Apr 30, 2024

balazsorban44 closed this Aug 8, 2024

auto-merge was automatically disabled August 8, 2024 19:37
Pull request was closed

github-actions bot added the locked label Aug 23, 2024

github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(test): use imported test mode instead of `global` in tests #63243

refactor(test): use imported test mode instead of `global` in tests #63243

balazsorban44 commented Mar 13, 2024 •

edited by padmaia

Loading

balazsorban44 commented Mar 13, 2024 •

edited

Loading

ijjk commented Mar 13, 2024 •

edited

Loading

ijjk commented Mar 13, 2024 •

edited

Loading

refactor(test): use imported test mode instead of global in tests #63243

refactor(test): use imported test mode instead of global in tests #63243

Conversation

balazsorban44 commented Mar 13, 2024 • edited by padmaia Loading

balazsorban44 commented Mar 13, 2024 • edited Loading

ijjk commented Mar 13, 2024 • edited Loading

Failing test suites

ijjk commented Mar 13, 2024 • edited Loading

Stats from current PR

refactor(test): use imported test mode instead of `global` in tests #63243

refactor(test): use imported test mode instead of `global` in tests #63243

balazsorban44 commented Mar 13, 2024 •

edited by padmaia

Loading

balazsorban44 commented Mar 13, 2024 •

edited

Loading

ijjk commented Mar 13, 2024 •

edited

Loading

ijjk commented Mar 13, 2024 •

edited

Loading