examples: remove app-dir and with prefix in the mdx directory name
#73458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
JamBalaya56562
force-pushed
the
mdx
branch
7 times, most recently
from
d8c24fb to
679be62
Compare
JamBalaya56562
force-pushed
the
mdx
branch
4 times, most recently
from
b1350ef to
4504933
Compare
|
@JamBalaya56562 It looks like there are conflicts now! |
JamBalaya56562
force-pushed
the
mdx
branch
2 times, most recently
from
45885e7 to
e2983ae
Compare
Thank you for checking! |
|
@JamBalaya56562 we should update |
Alright, I have made PR of that at #74067. This PR will be updated when #74067 is merged. |
|
@JamBalaya56562 The other PR has been merged! |
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
Why remove
app-dir-in the directory name?The default has already been App Router anyways and a lot of examples have migrated over.
x-ref: #72642 (comment)
Why remove
with-in the directory name?According to examples guidelines,
How did you verify your code works?
I have tested the new with-mdx.test.ts and example.test.ts.
Adding or Updating Examples
pnpm build && pnpm lint. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.mdCC: @samcx