Fix `unstable_allowDynamic` when used with pnpm #73732

unstubbable · 2024-12-10T10:47:18Z

When using dependencies in Middleware that make use of dynamic code evaluation, Next.js emits a build error because this is not supported in the Edge runtime.

In rare cases, when the code can not be reached at runtime and can't be removed by tree-shaking, users might opt in to using the unstable_allowDynamic config.

When combined with pnpm, the provided glob patterns as documented at https://nextjs.org/docs/messages/edge-dynamic-code-evaluation#possible-ways-to-fix-it did not match correctly because of pnpm's use of the .pnpm directory.

To fix the pattern matching, we need to provide the dot option to picomatch, which enables dotfile matching.

Side note: Ideally we would detect dynamic code evaluation after tree shaking, to reduce the number of cases where users need to revert to using unstable_allowDynamic.

fixes #51401

When using dependencies in Middleware that make use of dynamic code evaluation, Next.js emits a build error because this is not supported in the Edge runtime. In rare cases, when the code can not be reached at runtime and can't be removed by tree-shaking, users might opt in to using the `unstable_allowDynamic` config. When combined with pnpm, the provided glob patterns as documented at https://nextjs.org/docs/messages/edge-dynamic-code-evaluation#possible-ways-to-fix-it did not match correctly because of pnpm's use of the `.pnpm` directory. To fix the pattern matching, we need to provide the `dot` option to [picomatch](https://github.com/micromatch/picomatch), which enables dotfile matching. fixes #51401

ijjk · 2024-12-10T10:51:32Z

Tests Passed

ijjk · 2024-12-10T10:55:35Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js hl/fix-unstable_allowDynamic	Change
buildDuration	21.1s	18.8s	N/A
buildDurationCached	18.2s	15.9s	N/A
nodeModulesSize	409 MB	409 MB	⚠️ +312 B
nextStartRea..uration (ms)	474ms	474ms	✓

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js hl/fix-unstable_allowDynamic	Change
1187-HASH.js gzip	50.2 kB	50.2 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.3 kB	5.3 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	232 B	234 B	N/A
main-HASH.js gzip	33.8 kB	33.7 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js hl/fix-unstable_allowDynamic	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js hl/fix-unstable_allowDynamic	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.44 kB	4.43 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js hl/fix-unstable_allowDynamic	Change
_buildManifest.js gzip	747 B	745 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js hl/fix-unstable_allowDynamic	Change
index.html gzip	524 B	523 B	N/A
link.html gzip	538 B	538 B	✓
withRouter.html gzip	520 B	520 B	✓
Overall change	1.06 kB	1.06 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js hl/fix-unstable_allowDynamic	Change
edge-ssr.js gzip	128 kB	128 kB	N/A
page.js gzip	203 kB	203 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js hl/fix-unstable_allowDynamic	Change
middleware-b..fest.js gzip	670 B	668 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31 kB	31 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js hl/fix-unstable_allowDynamic	Change
523-experime...dev.js gzip	322 B	322 B	✓
523.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	322 kB	322 kB	✓
app-page-exp..prod.js gzip	127 kB	127 kB	✓
app-page-tur..prod.js gzip	140 kB	140 kB	✓
app-page-tur..prod.js gzip	135 kB	135 kB	✓
app-page.run...dev.js gzip	312 kB	312 kB	✓
app-page.run..prod.js gzip	122 kB	122 kB	✓
app-route-ex...dev.js gzip	37.1 kB	37.1 kB	✓
app-route-ex..prod.js gzip	25.1 kB	25.1 kB	✓
app-route-tu..prod.js gzip	25.1 kB	25.1 kB	✓
app-route-tu..prod.js gzip	24.9 kB	24.9 kB	✓
app-route.ru...dev.js gzip	38.7 kB	38.7 kB	✓
app-route.ru..prod.js gzip	24.9 kB	24.9 kB	✓
pages-api-tu..prod.js gzip	9.56 kB	9.56 kB	✓
pages-api.ru...dev.js gzip	11.4 kB	11.4 kB	✓
pages-api.ru..prod.js gzip	9.56 kB	9.56 kB	✓
pages-turbo...prod.js gzip	21.3 kB	21.3 kB	✓
pages.runtim...dev.js gzip	27 kB	27 kB	✓
pages.runtim..prod.js gzip	21.3 kB	21.3 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.35 MB	2.35 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js hl/fix-unstable_allowDynamic	Change
0.pack gzip	2.04 MB	2.04 MB	N/A
index.pack gzip	146 kB	146 kB	⚠️ +195 B
Overall change	146 kB	146 kB	⚠️ +195 B

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 640964f

unstubbable · 2024-12-10T13:48:48Z

Apply SWC transforms for Middleware also to 3rd-party code #73740
Fix unstable_allowDynamic when used with pnpm #73732 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

> [!NOTE] > This is a backport of #73732 for Next.js 14. When using dependencies in Middleware that make use of dynamic code evaluation, Next.js emits a build error because this is not supported in the Edge runtime. In rare cases, when the code can not be reached at runtime and can't be removed by tree-shaking, users might opt in to using the `unstable_allowDynamic` config. When combined with pnpm, the provided glob patterns as documented at https://nextjs.org/docs/messages/edge-dynamic-code-evaluation#possible-ways-to-fix-it did not match correctly because of pnpm's use of the `.pnpm` directory. To fix the pattern matching, we need to provide the `dot` option to [picomatch](https://github.com/micromatch/picomatch), which enables dotfile matching. _Side note: Ideally we would detect dynamic code evaluation after tree shaking, to reduce the number of cases where users need to revert to using `unstable_allowDynamic`._ fixes #51401

ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. tests type: next labels Dec 10, 2024

Disable some tests for Turbopack temporarily

640964f

unstubbable mentioned this pull request Dec 10, 2024

Apply SWC transforms for Middleware also to 3rd-party code #73740

Draft

unstubbable marked this pull request as ready for review December 10, 2024 19:30

ijjk approved these changes Dec 10, 2024

View reviewed changes

unstubbable merged commit 7db3bf7 into canary Dec 10, 2024
117 checks passed

unstubbable deleted the hl/fix-unstable_allowDynamic branch December 10, 2024 21:14

huozhi approved these changes Dec 10, 2024

View reviewed changes

unstubbable mentioned this pull request Dec 10, 2024

Backport: Fix unstable_allowDynamic when used with pnpm #73765

Merged

leerob mentioned this pull request Dec 16, 2024

Update edge-dynamic-code-evaluation.mdx #64844

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `unstable_allowDynamic` when used with pnpm #73732

Fix `unstable_allowDynamic` when used with pnpm #73732

unstubbable commented Dec 10, 2024 •

edited

Loading

ijjk commented Dec 10, 2024 •

edited

Loading

ijjk commented Dec 10, 2024 •

edited

Loading

unstubbable commented Dec 10, 2024 •

edited

Loading

Fix unstable_allowDynamic when used with pnpm #73732

Fix unstable_allowDynamic when used with pnpm #73732

Conversation

unstubbable commented Dec 10, 2024 • edited Loading

ijjk commented Dec 10, 2024 • edited Loading

Tests Passed

ijjk commented Dec 10, 2024 • edited Loading

Stats from current PR

unstubbable commented Dec 10, 2024 • edited Loading

Fix `unstable_allowDynamic` when used with pnpm #73732

Fix `unstable_allowDynamic` when used with pnpm #73732

unstubbable commented Dec 10, 2024 •

edited

Loading

ijjk commented Dec 10, 2024 •

edited

Loading

ijjk commented Dec 10, 2024 •

edited

Loading

unstubbable commented Dec 10, 2024 •

edited

Loading