Apply SWC transforms for Middleware also to 3rd-party code

[unstubbable]

This aligns Turbopack with what Webpack is already doing in this regard.

What this doesn't enable though is emitting build errors when using the disallowed APIs. Just enabling it for 3rd-party code in the SWC transforms wouldn't be sufficient. This would lead to too many false positives, because it's applied before tree shaking. We would need to change that first so that the detection and emitting errors is done after tree-shaking, as is already the case with Webpack.

[unstubbable]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Apply SWC transforms for Middleware also to 3rd-party code #73740 👈 (View in Graphite)
• Fix unstable_allowDynamic when used with pnpm #73732
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ijjk]

Failing test suites

Commit: d30df3b

pnpm test-dev test/development/acceptance-app/hydration-error.test.ts

• Error overlay for hydration errors in App router > should show the highlighted bad nesting html snippet when bad nesting happened

Expand output

● Error overlay for hydration errors in App router › should show the highlighted bad nesting html snippet when bad nesting happened

expect(received).toBe(expected) // Object.is equality

Expected: 2
Received: 1

  716 |     await session.openRedbox()
  717 |
> 718 |     expect(await getRedboxTotalErrorCount(browser)).toBe(2)
      |                                                     ^
  719 |
  720 |     const description = await session.getRedboxDescription()
  721 |     expect(description).toContain(

  at Object.toBe (development/acceptance-app/hydration-error.test.ts:718:53)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js hl/edge-transforms-for-foreign-code	Change
buildDuration	17.8s	15.7s	N/A
buildDurationCached	14.9s	12.5s	N/A
nodeModulesSize	409 MB	409 MB	✓
nextStartRea..uration (ms)	467ms	474ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js hl/edge-transforms-for-foreign-code	Change
1187-HASH.js gzip	50.4 kB	50.4 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.3 kB	5.3 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	232 B	235 B	N/A
main-HASH.js gzip	33.8 kB	33.7 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js hl/edge-transforms-for-foreign-code	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js hl/edge-transforms-for-foreign-code	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.44 kB	4.43 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js hl/edge-transforms-for-foreign-code	Change
_buildManifest.js gzip	747 B	745 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js hl/edge-transforms-for-foreign-code	Change
index.html gzip	524 B	523 B	N/A
link.html gzip	539 B	537 B	N/A
withRouter.html gzip	520 B	520 B	✓
Overall change	520 B	520 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js hl/edge-transforms-for-foreign-code	Change
edge-ssr.js gzip	128 kB	128 kB	N/A
page.js gzip	203 kB	203 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js hl/edge-transforms-for-foreign-code	Change
middleware-b..fest.js gzip	670 B	665 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31 kB	31 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js hl/edge-transforms-for-foreign-code	Change
523-experime...dev.js gzip	322 B	322 B	✓
523.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	322 kB	322 kB	✓
app-page-exp..prod.js gzip	127 kB	127 kB	✓
app-page-tur..prod.js gzip	140 kB	140 kB	✓
app-page-tur..prod.js gzip	135 kB	135 kB	✓
app-page.run...dev.js gzip	312 kB	312 kB	✓
app-page.run..prod.js gzip	122 kB	122 kB	✓
app-route-ex...dev.js gzip	37.1 kB	37.1 kB	✓
app-route-ex..prod.js gzip	25.1 kB	25.1 kB	✓
app-route-tu..prod.js gzip	25.1 kB	25.1 kB	✓
app-route-tu..prod.js gzip	24.9 kB	24.9 kB	✓
app-route.ru...dev.js gzip	38.7 kB	38.7 kB	✓
app-route.ru..prod.js gzip	24.9 kB	24.9 kB	✓
pages-api-tu..prod.js gzip	9.56 kB	9.56 kB	✓
pages-api.ru...dev.js gzip	11.4 kB	11.4 kB	✓
pages-api.ru..prod.js gzip	9.56 kB	9.56 kB	✓
pages-turbo...prod.js gzip	21.3 kB	21.3 kB	✓
pages.runtim...dev.js gzip	27 kB	27 kB	✓
pages.runtim..prod.js gzip	21.3 kB	21.3 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.35 MB	2.35 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js hl/edge-transforms-for-foreign-code	Change
0.pack gzip	2.03 MB	2.03 MB	⚠️ +615 B
index.pack gzip	72.9 kB	71.9 kB	N/A
Overall change	2.03 MB	2.03 MB	⚠️ +615 B

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: d30df3b