-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Timeout should be configureable #2280
Comments
That seems reasonable. Few follow ups:
|
HI @mehulkar thanks for the comments!
|
Reasonable ask. If you're up for making a PR, go for it! |
@mehulkar This is actually a duplicate of #2096. I'm wondering if @kathleenfrench would still be willing to make the PR she had talked about in her previous ticket |
Thanks for hunting that down! Closing this in favor of the older #2096. (If you could update your "fixes" in the PR too, that would be great 😄 ) |
Describe the feature you'd like to request
See: #1993
There is a timeout hardcoded here:
turborepo/cli/internal/client/client.go
Line 77 in d79261f
This causes timeouts for assets that take more than 20s to upload (like over my slow home connection to a remote)
Note: This used to be a timeout of 60 seconds but was changed to 20 in this PR: #545
Describe the solution you'd like
The timeout should be configurable
Describe alternatives you've considered
I've tried different implementations but ultimately its because my home internet connection is not fast enough to upload the asset in under 20 seconds
The text was updated successfully, but these errors were encountered: