Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Timeout should be configureable #2280

Closed
tm1000 opened this issue Oct 19, 2022 · 5 comments
Closed

Client Timeout should be configureable #2280

tm1000 opened this issue Oct 19, 2022 · 5 comments
Labels
area: ergonomics Issues and features impacting the developer experience of using turbo

Comments

@tm1000
Copy link
Contributor

tm1000 commented Oct 19, 2022

Describe the feature you'd like to request

See: #1993

There is a timeout hardcoded here:

Timeout: time.Duration(20 * time.Second),

This causes timeouts for assets that take more than 20s to upload (like over my slow home connection to a remote)

Note: This used to be a timeout of 60 seconds but was changed to 20 in this PR: #545

Describe the solution you'd like

The timeout should be configurable

Describe alternatives you've considered

I've tried different implementations but ultimately its because my home internet connection is not fast enough to upload the asset in under 20 seconds

@mehulkar
Copy link
Contributor

mehulkar commented Oct 20, 2022

That seems reasonable. Few follow ups:

  • Would you expect this to be a user configurable number (given your use case) or something in the turbo.json config? It could go into the remoteCache config or be a CLI arg. (which I notice now isn't documented in our Configuration options)
  • Does it only apply to the remote cache upload/download bit or would a timeout also apply to the entire command turbo is running?

@tm1000
Copy link
Contributor Author

tm1000 commented Oct 20, 2022

HI @mehulkar thanks for the comments!

  • In the turbo.json is fine (didnt know about the remoteCache config myself). Really whatever is easier for you to program
  • It only applies to upload/download not the entire command turbo is running.

@mehulkar mehulkar added area: ergonomics Issues and features impacting the developer experience of using turbo pkg: turbo-cli labels Oct 20, 2022
@mehulkar
Copy link
Contributor

Reasonable ask. If you're up for making a PR, go for it!

@tm1000
Copy link
Contributor Author

tm1000 commented Oct 27, 2022

@mehulkar This is actually a duplicate of #2096. I'm wondering if @kathleenfrench would still be willing to make the PR she had talked about in her previous ticket

@mehulkar
Copy link
Contributor

Thanks for hunting that down! Closing this in favor of the older #2096. (If you could update your "fixes" in the PR too, that would be great 😄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ergonomics Issues and features impacting the developer experience of using turbo
Projects
None yet
Development

No branches or pull requests

2 participants