Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hitting remote cache after a few failures #545

Merged
merged 12 commits into from
Feb 18, 2022
Merged

Conversation

jaredpalmer
Copy link
Contributor

@jaredpalmer jaredpalmer commented Jan 11, 2022

Close #541

When the remote cache fails or timesout more than n times (twice at the moment), turbo will cease trying to hit the remote cache.

@vercel
Copy link

vercel bot commented Jan 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/7ZZgsHnrn18J3mMabmEB9rcXpcDJ
✅ Preview: https://turbo-site-git-smart-remote-failure.vercel.sh

gaspar09
gaspar09 previously approved these changes Feb 9, 2022
@jaredpalmer jaredpalmer added pr: automerge Kodiak will merge these automatically after checks pass and removed pr: automerge Kodiak will merge these automatically after checks pass labels Feb 9, 2022
cli/internal/client/client.go Outdated Show resolved Hide resolved
cli/internal/client/client.go Outdated Show resolved Hide resolved
cli/internal/client/client.go Outdated Show resolved Hide resolved
cli/internal/client/client.go Outdated Show resolved Hide resolved
cli/internal/client/client.go Outdated Show resolved Hide resolved
cli/internal/client/client.go Outdated Show resolved Hide resolved
cli/internal/cache/cache.go Show resolved Hide resolved
cli/internal/cache/cache.go Outdated Show resolved Hide resolved
cli/internal/client/client.go Outdated Show resolved Hide resolved
Apply review suggestions to remote failure PR
@jaredpalmer jaredpalmer added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 18, 2022
@kodiakhq kodiakhq bot merged commit b567c5b into main Feb 18, 2022
@kodiakhq kodiakhq bot deleted the smart-remote-failure branch February 18, 2022 19:43
Copy link
Contributor

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's coming along.

One general Go comment to add: for methods or functions that are not intended to be used outside of a package, they can be kept private by starting the name with a lowercase letter. So IsProtocolExternal can be isProtocolExternal. Test code is typically part of the same package, so this does not impact the ability to write tests for this code.

Along those lines, it might be nice to have a quick test demonstrating some typical internal vs external references.

@jaredpalmer
Copy link
Contributor Author

What's this in reference to @gsoltis ?

@gsoltis
Copy link
Contributor

gsoltis commented Mar 3, 2022

Whoa, weird, that was a comment I made for a different PR authored via VSCode. I was wondering where it went...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build waits 90 seconds between packages when caching server is offline
3 participants