add sveltekit example #1184
Closed
add sveltekit example #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephDietz
requested review from
jaredpalmer,
gsoltis,
gaspar09 and
nathanhammond
as code owners
|
@StephDietz is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
nathanhammond
suggested changes
May 5, 2022
There was a problem hiding this comment.
Heya @StephDietz! Thanks for prepping this!
Unfortunately, the create-turbo version you were using didn't contain the changes from #1172 and #1174. We need a version of this which is built on top of those changes.
- You can use
npx create-turbo@canaryto get those changes. - We should replace the
webanddocsnextapps with Svelte apps instead of standing up more things likely just going to need to be be deleted inside of the repo. - Then, since we dropped
next, we should modify theeslint-config-customto not use thenextconfig and instead use svelte stuff.
There's probably more little fiddly bits as well, but that's a good picture of things that I already know we need to be address.
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
A basic svelte example. Replaces #1184 and #244 **NOTE**: There is no shared `ts-config` package here because of how svelte sets up it's ts-config inheritance. The base config is auto generated in a set location (`.svelte-kit`). There are a few open issues about adjusting this for better monorepo support (relevant issues: sveltejs/kit#4052, microsoft/TypeScript#29118 (comment))
|
Closed in favor of #1458 |
yeabu369
pushed a commit
to yeabu369/afrovalleyio
that referenced
this pull request
Dec 31, 2022
A basic svelte example. Replaces vercel/turborepo#1184 and vercel/turborepo#244 **NOTE**: There is no shared `ts-config` package here because of how svelte sets up it's ts-config inheritance. The base config is auto generated in a set location (`.svelte-kit`). There are a few open issues about adjusting this for better monorepo support (relevant issues: sveltejs/kit#4052, microsoft/TypeScript#29118 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes