Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Svelte example #244

Closed
wants to merge 5 commits into from
Closed

Add Svelte example #244

wants to merge 5 commits into from

Conversation

jaredpalmer
Copy link
Contributor

@jaredpalmer jaredpalmer commented Dec 13, 2021

  • Needs example README.md
  • Needs ui to use typescript (it currently only uses .mjs)?
  • Need to update each application's readme with deployment instructions
  • (bonus) abstract eslint configuration into a separate config package and use it in docs, web, ui
  • Need to add typechecking to turbo pipeline

@vercel
Copy link

vercel bot commented Dec 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/5uKBp1UU5ZYKeMS252piz4ByHyJ2
✅ Preview: https://turbo-site-git-examples-svelte.vercel.sh

@jaredpalmer jaredpalmer added the area: docs Improvements or additions to documentation label Dec 20, 2021
@vercel
Copy link

vercel bot commented Apr 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Deployment Preview Updated
turbo-site Deployed View Apr 13, 2022 at 8:52PM (UTC)

kodiakhq bot pushed a commit that referenced this pull request Jun 29, 2022
A basic svelte example. 

Replaces #1184 and #244

**NOTE**: There is no shared `ts-config` package here because of how svelte sets up it's ts-config inheritance. The base config is auto generated in a set location (`.svelte-kit`). There are a few open issues about adjusting this for better monorepo support (relevant issues: sveltejs/kit#4052, microsoft/TypeScript#29118 (comment))
@tknickman
Copy link
Member

Closed in favor of #1458

@tknickman tknickman closed this Jun 29, 2022
sokra pushed a commit that referenced this pull request Oct 25, 2022
This implements a benchmark of restarting the devserver after successfully starting it and shutting it down.

## Question/TODO: 

Since our goal is metrics that don't scale with project size, should we
assert that the small/medium benchmark results don't differ?

Test Plan: `cargo bench -p next-dev`
sokra pushed a commit that referenced this pull request Oct 25, 2022
Made the images landscape

Co-authored-by: Gaspar Garcia Jr <gaspar@vercel.com>
yeabu369 pushed a commit to yeabu369/afrovalleyio that referenced this pull request Dec 31, 2022
A basic svelte example. 

Replaces vercel/turborepo#1184 and vercel/turborepo#244

**NOTE**: There is no shared `ts-config` package here because of how svelte sets up it's ts-config inheritance. The base config is auto generated in a set location (`.svelte-kit`). There are a few open issues about adjusting this for better monorepo support (relevant issues: sveltejs/kit#4052, microsoft/TypeScript#29118 (comment))
@ForsakenHarmony ForsakenHarmony deleted the examples/svelte branch January 9, 2023 16:46
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
This implements a benchmark of restarting the devserver after successfully starting it and shutting it down.

## Question/TODO: 

Since our goal is metrics that don't scale with project size, should we
assert that the small/medium benchmark results don't differ?

Test Plan: `cargo bench -p next-dev`
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
This implements a benchmark of restarting the devserver after successfully starting it and shutting it down.

## Question/TODO: 

Since our goal is metrics that don't scale with project size, should we
assert that the small/medium benchmark results don't differ?

Test Plan: `cargo bench -p next-dev`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation area: examples Improvements or additions to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants