Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter out invalid Pipelines from TurboJSON when running turbo prune #3216

Merged
merged 4 commits into from
Jan 27, 2023
Merged

filter out invalid Pipelines from TurboJSON when running turbo prune #3216

merged 4 commits into from
Jan 27, 2023

Conversation

arlyon
Copy link
Contributor

@arlyon arlyon commented Jan 9, 2023 •
edited
Loading

Closes #1161

This is based on top of #3213

Open questions:

  • do we want to include root-scoped tasks in the output?
  • what should the permissions be on the new turbo file created? we could read the permissions from the old one, or set it manually (I currently do 0664)

@arlyon arlyon requested a review from a team as a code owner January 9, 2023 13:05
@vercel
Copy link

vercel bot commented Jan 9, 2023

@arlyon is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jan 9, 2023

You must have Developer access to commit code to Vercel on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/concepts/teams/roles-and-permissions#enterprise-team-account-roles

@arlyon arlyon marked this pull request as draft January 9, 2023 13:05
@arlyon arlyon changed the title WIP: filter out Pipelines from TurboJSON when running turbo prune WIP: filter out invalid Pipelines from TurboJSON when running turbo prune Jan 9, 2023
@vercel
Copy link

vercel bot commented Jan 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web 🔄 Building (Inspect) Visit Preview Jan 27, 2023 at 6:43PM (UTC)
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview Jan 27, 2023 at 6:43PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 6:43PM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2023 at 6:43PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2023 at 6:43PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2023 at 6:43PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2023 at 6:43PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2023 at 6:43PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2023 at 6:43PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Jan 27, 2023 at 6:43PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2023 at 6:43PM (UTC)

@arlyon arlyon marked this pull request as ready for review January 10, 2023 14:52
@arlyon arlyon changed the title WIP: filter out invalid Pipelines from TurboJSON when running turbo prune filter out invalid Pipelines from TurboJSON when running turbo prune Jan 10, 2023
arlyon
arlyon commented Jan 10, 2023
View reviewed changes
cli/scripts/e2e/e2e.ts Outdated Show resolved Hide resolved
nathanhammond
nathanhammond previously requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@nathanhammond nathanhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some notes!

cli/internal/prune/prune.go Show resolved Hide resolved
cli/internal/util/task_id.go Show resolved Hide resolved
cli/internal/prune/prune.go Outdated Show resolved Hide resolved
cli/internal/prune/prune.go Outdated Show resolved Hide resolved
cli/internal/prune/prune.go Outdated Show resolved Hide resolved
cli/scripts/e2e/e2e.ts Outdated Show resolved Hide resolved
cli/scripts/e2e/e2e.ts Outdated Show resolved Hide resolved
nathanhammond
nathanhammond reviewed Jan 18, 2023
View reviewed changes
cli/internal/prune/prune.go Outdated Show resolved Hide resolved
cli/internal/prune/prune.go Outdated Show resolved Hide resolved
cli/internal/prune/prune.go Outdated Show resolved Hide resolved
@arlyon arlyon force-pushed the fix/issue-1161 branch 2 times, most recently from e72532d to f5a96b6 Compare January 25, 2023 10:29
@arlyon arlyon dismissed nathanhammond’s stale review January 25, 2023 10:33

Addressed all the mentioned issues.

tknickman
tknickman approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note about the requirement for .gitignore, bother otherwise lgtm

@arlyon arlyon force-pushed the fix/issue-1161 branch 2 times, most recently from c43ea14 to 977a278 Compare January 27, 2023 18:04
@arlyon arlyon enabled auto-merge (squash) January 27, 2023 18:04
@arlyon arlyon merged commit 18e703b into vercel:main Jan 27, 2023
@eden eden mentioned this pull request Feb 1, 2023
Closed
@chris-olszewski chris-olszewski mentioned this pull request Feb 13, 2023
Merged
@arlyon arlyon deleted the fix/issue-1161 branch March 1, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tknickman tknickman tknickman approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run command when package#task defined turbo.json is missing
3 participants
@arlyon @nathanhammond @tknickman